language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-29 05:15:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

don't use volatile queries

Browse source 
"volatile" means "changes every time". That is, all transitive
rev-deps of volatile queries will be executed every time. We actually
need "dependencies".
This commit is contained in:
Aleksey Kladov 2018-11-27 17:39:58 +03:00
parent 0bc6f5802f
commit 6bb06addf8
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ra_analysis/src/db.rs
View file

@ -149,7 +149,7 @@ salsa::query_group! {
fn resolve_syntax_ptr(ptr: SyntaxPtr) -> SyntaxNode { fn resolve_syntax_ptr(ptr: SyntaxPtr) -> SyntaxNode {
type ResolveSyntaxPtrQuery; type ResolveSyntaxPtrQuery;
// Don't retain syntax trees in memory // Don't retain syntax trees in memory
storage volatile; storage dependencies;
use fn crate::syntax_ptr::resolve_syntax_ptr; use fn crate::syntax_ptr::resolve_syntax_ptr;
} }
} }

6
crates/ra_analysis/src/descriptors/mod.rs
View file

@ -32,13 +32,13 @@ salsa::query_group! {
fn _file_items(file_id: FileId) -> Arc<FileItems> { fn _file_items(file_id: FileId) -> Arc<FileItems> {
type FileItemsQuery; type FileItemsQuery;
storage volatile; storage dependencies;
use fn module::nameres::file_items; use fn module::nameres::file_items;
} }
fn _file_item(file_id: FileId, file_item_id: FileItemId) -> SyntaxNode { fn _file_item(file_id: FileId, file_item_id: FileItemId) -> SyntaxNode {
type FileItemQuery; type FileItemQuery;
storage volatile; storage dependencies;
use fn module::nameres::file_item; use fn module::nameres::file_item;
} }
@ -57,7 +57,7 @@ salsa::query_group! {
fn _fn_syntax(fn_id: FnId) -> FnDefNode { fn _fn_syntax(fn_id: FnId) -> FnDefNode {
type FnSyntaxQuery; type FnSyntaxQuery;
// Don't retain syntax trees in memory // Don't retain syntax trees in memory
storage volatile; storage dependencies;
use fn function::imp::fn_syntax; use fn function::imp::fn_syntax;
} }
fn _submodules(source: ModuleSource) -> Cancelable<Arc<Vec<module::imp::Submodule>>> { fn _submodules(source: ModuleSource) -> Cancelable<Arc<Vec<module::imp::Submodule>>> {