language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-29 05:15:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

internal: make CompletionItem and SourceChange consistent

Browse source 
Before this PR, SourceChange used a bool and CompletionItem used an enum
to signify if edit is a snippet. It makes sense to use the same pattern
in both cases. `bool` feels simpler, as there's only one consumer of
this API, and all producers are encapsulated anyway (we check the
capability at the production site).
This commit is contained in:
Aleksey Kladov 2021-07-04 15:41:28 +03:00
parent 2ce88b504c
commit 6e9780c005
4 changed files with 16 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ide_completion/src/lib.rs
View file

@ -25,7 +25,7 @@ use crate::{completions::Completions, context::CompletionContext, item::Completi
pub use crate::{
config::CompletionConfig,
item::{CompletionItem, CompletionItemKind, CompletionRelevance, ImportEdit, InsertTextFormat},
item::{CompletionItem, CompletionItemKind, CompletionRelevance, ImportEdit},
};
//FIXME: split the following feature into fine-grained features.