language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-29 13:25:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Add new configuration "enableEnhancedTyping" to control registering of "type" command

Browse source 
This further fixes problems when having a VIM extension (at least vscodevim)
enabled, by not calling `overrideCommand('type', commands.onEnter.handle)` when
enableEnhancedTyping is set to `false`.

The problem is dependent on the order in which extensions are activated, if
rust-analyzer is activated before `vscodevim`, rust-analyzer will register the
`type` command, and when `vscodevim` finally attempts to activate, it will fail
to register the command. This causes `vscodevim` to stop working properly.

This setting allows users to disable the registerCommand `type` in
rust-analyzer, allowing `vscodevim` to work. The setting defaults to `true`.

Currently changing the setting requires reloading of the window.
This commit is contained in:
Ville Penttinen 2019-02-07 12:37:36 +02:00
parent 736a55c97e
commit 77a4a311fe
3 changed files with 33 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
editors/code/src/extension.ts
View file

@ -82,7 +82,9 @@ export function activate(context: vscode.ExtensionContext) {
}
);
overrideCommand('type', commands.onEnter.handle);
if (Server.config.enableEnhancedTyping) {
overrideCommand('type', commands.onEnter.handle);
}
// Notifications are events triggered by the language server
const allNotifications: Iterable<