language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-08-10 21:58:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Disallow renaming of non-local structs

Browse source
This commit is contained in:
Ali Bektas 2023-07-08 02:39:03 +02:00
parent 326f37ef1f
commit 7ae70a06ce
2 changed files with 28 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/ide-db/src/rename.rs
View file

@ -22,7 +22,7 @@
//! Our current behavior is ¯\_(ツ)_/¯.
use std::fmt;
use base_db::{AnchoredPathBuf, FileId, FileRange};
use base_db::{AnchoredPathBuf, CrateOrigin, FileId, FileRange};
use either::Either;
use hir::{FieldSource, HasSource, InFile, ModuleSource, Semantics};
use stdx::never;
@ -77,6 +77,15 @@ impl Definition {
bail!("Cannot rename builtin type")
}
Definition::SelfType(_) => bail!("Cannot rename `Self`"),
Definition::Adt(hir::Adt::Struct(strukt)) => {
if !matches!(
strukt.module(sema.db).krate().origin(sema.db),
CrateOrigin::Local { .. }
) {
bail!("Cannot rename a non-local struct.")
}
rename_reference(sema, Definition::Adt(hir::Adt::Struct(strukt)), new_name)
}
def => rename_reference(sema, def, new_name),
}
}