language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-27 20:42:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

update: make each trait_impl_reduntant_assoc_item into individual diagnostic

Browse source
This commit is contained in:
Young-Flash 2023-12-01 19:09:42 +08:00
parent 5d84edd430
commit 861e47431b
5 changed files with 91 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

22
crates/hir/src/lib.rs
View file

@ -693,20 +693,20 @@ impl Module {
},
));
let reduntant: Vec<_> = impl_assoc_items_scratch.iter()
.filter(|(id, name)| {
!required_items.clone().any(|(impl_name, impl_item)| {
discriminant(impl_item) == discriminant(id) && impl_name == name
let redundant = impl_assoc_items_scratch
.iter()
.filter(|(id, name)| {
!items.iter().any(|(impl_name, impl_item)| {
discriminant(impl_item) == discriminant(id) && impl_name == name
})
})
})
.map(|(item, name)| (name.clone(), AssocItem::from(*item)))
.collect();
if !reduntant.is_empty() {
.map(|(item, name)| (name.clone(), AssocItem::from(*item)));
for (name, assoc_item) in redundant {
acc.push(
TraitImplReduntantAssocItems {
impl_: ast_id_map.get(node.ast_id()),
TraitImplRedundantAssocItems {
trait_,
file_id,
reduntant,
assoc_item: (name, assoc_item),
}
.into(),
)