use arena for sysroot

crates/ra_arena/src/lib.rs

@@ -35,12 +35,21 @@ impl fmt::Display for RawId {
     }
 }
 
-#[derive(Clone, Debug, PartialEq, Eq)]
+#[derive(Clone, PartialEq, Eq)]
 pub struct Arena<ID: ArenaId, T> {
     data: Vec<T>,
     _ty: PhantomData<ID>,
 }
 
+impl<ID: ArenaId, T: fmt::Debug> fmt::Debug for Arena<ID, T> {
+    fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
+        fmt.debug_struct("Arena")
+            .field("len", &self.len())
+            .field("data", &self.data)
+            .finish()
+    }
+}
+
 #[macro_export]
 macro_rules! impl_arena_id {
     ($name:ident) => {

crates/ra_lsp_server/src/project_model/sysroot.rs

@@ -4,13 +4,24 @@ use std::{
 };
 
 use ra_syntax::SmolStr;
-use rustc_hash::FxHashMap;
+use ra_arena::{Arena, RawId, impl_arena_id};
 
 use crate::Result;
 
 #[derive(Debug, Clone)]
 pub struct Sysroot {
-    crates: FxHashMap<SmolStr, PathBuf>,
+    crates: Arena<SysrootCrate, SysrootCrateData>,
+}
+
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
+pub struct SysrootCrate(RawId);
+impl_arena_id!(SysrootCrate);
+
+#[derive(Debug, Clone)]
+struct SysrootCrateData {
+    name: SmolStr,
+    path: PathBuf,
+    deps: Vec<SysrootCrate>,
 }
 
 impl Sysroot {
@@ -26,53 +37,73 @@ impl Sysroot {
         let sysroot_path = Path::new(stdout.trim());
         let src = sysroot_path.join("lib/rustlib/src/rust/src");
 
-        let crates: &[(&str, &[&str])] = &[
+        let mut sysroot = Sysroot {
-            (
+            crates: Arena::default(),
-                "std",
+        };
-                &[
+        for name in SYSROOT_CRATES.trim().lines() {
-                    "alloc_jemalloc",
+            let path = src.join(format!("lib{}", name)).join("lib.rs");
-                    "alloc_system",
+            if path.exists() {
-                    "panic_abort",
+                sysroot.crates.alloc(SysrootCrateData {
-                    "rand",
+                    name: name.into(),
-                    "compiler_builtins",
+                    path,
-                    "unwind",
+                    deps: Vec::new(),
-                    "rustc_asan",
+                });
-                    "rustc_lsan",
+            }
-                    "rustc_msan",
+        }
-                    "rustc_tsan",
+        if let Some(std) = sysroot.by_name("std") {
-                    "build_helper",
+            for dep in STD_DEPS.trim().lines() {
-                ],
+                if let Some(dep) = sysroot.by_name(dep) {
-            ),
+                    sysroot.crates[std].deps.push(dep)
-            ("core", &[]),
+                }
-            ("alloc", &[]),
+            }
-            ("collections", &[]),
+        }
-            ("libc", &[]),
+        Ok(sysroot)
-            ("panic_unwind", &[]),
+    }
-            ("proc_macro", &[]),
-            ("rustc_unicode", &[]),
-            ("std_unicode", &[]),
-            ("test", &[]),
-            // Feature gated
-            ("alloc_jemalloc", &[]),
-            ("alloc_system", &[]),
-            ("compiler_builtins", &[]),
-            ("getopts", &[]),
-            ("panic_unwind", &[]),
-            ("panic_abort", &[]),
-            ("rand", &[]),
-            ("term", &[]),
-            ("unwind", &[]),
-            // Dependencies
-            ("build_helper", &[]),
-            ("rustc_asan", &[]),
-            ("rustc_lsan", &[]),
-            ("rustc_msan", &[]),
-            ("rustc_tsan", &[]),
-            ("syntax", &[]),
-        ];
 
-        Ok(Sysroot {
+    fn by_name(&self, name: &str) -> Option<SysrootCrate> {
-            crates: FxHashMap::default(),
+        self.crates
-        })
+            .iter()
+            .find(|(_id, data)| data.name == name)
+            .map(|(id, _data)| id)
     }
 }
+
+const SYSROOT_CRATES: &str = "
+std
+core
+alloc
+collections
+libc
+panic_unwind
+proc_macro
+rustc_unicode
+std_unicode
+test
+alloc_jemalloc
+alloc_system
+compiler_builtins
+getopts
+panic_unwind
+panic_abort
+rand
+term
+unwind
+build_helper
+rustc_asan
+rustc_lsan
+rustc_msan
+rustc_tsan
+syntax";
+
+const STD_DEPS: &str = "
+alloc_jemalloc
+alloc_system
+panic_abort
+rand
+compiler_builtins
+unwind
+rustc_asan
+rustc_lsan
+rustc_msan
+rustc_tsan
+build_helper";