language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-03 07:04:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Properly resolve intra doc links in hover and goto_definition

Browse source
This commit is contained in:
Lukas Wirth 2021-03-29 21:23:45 +02:00
parent 0b68e03bf5
commit 9df78ec4a4
4 changed files with 104 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

24
crates/ide/src/goto_definition.rs
View file

@ -31,7 +31,8 @@ pub(crate) fn goto_definition(
let token = sema.descend_into_macros(original_token.clone());
let parent = token.parent()?;
if let Some(comment) = ast::Comment::cast(token) {
let (_, link, ns) = extract_positioned_link_from_comment(position.offset, &comment)?;
let docs = doc_owner_to_def(&sema, &parent)?.docs(db)?;
let (_, link, ns) = extract_positioned_link_from_comment(position.offset, &comment, docs)?;
let def = doc_owner_to_def(&sema, &parent)?;
let nav = resolve_doc_path_for_def(db, def, &link, ns)?.try_to_nav(db)?;
return Some(RangeInfo::new(original_token.text_range(), vec![nav]));
@ -1158,4 +1159,25 @@ fn fn_macro() {}
"#,
)
}
#[test]
fn goto_intra_doc_links() {
check(
r#"
pub mod theitem {
/// This is the item. Cool!
pub struct TheItem;
//^^^^^^^
}
/// Gives you a [`TheItem$0`].
///
/// [`TheItem`]: theitem::TheItem
pub fn gimme() -> theitem::TheItem {
theitem::TheItem
}
"#,
);
}
}