language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-11-02 04:48:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Remove rename_self_outside_of_methods

Browse source
This commit is contained in:
A4-Tacks 2025-07-23 22:04:59 +08:00
parent 4b32a49ef1
commit 9ecd82be13
No known key found for this signature in database
GPG key ID: 86AC1F526BA06668
1 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/ide/src/rename.rs
View file

@ -473,12 +473,7 @@ fn text_edit_from_self_param(self_param: &ast::SelfParam, new_name: String) -> O
replacement_text.push_str("mut ");
}
if self_param.syntax().ancestors().find_map(ast::Impl::cast).is_some() {
replacement_text.push_str("Self");
} else {
cov_mark::hit!(rename_self_outside_of_methods);
replacement_text.push('_');
}
replacement_text.push_str("Self");
Some(TextEdit::replace(self_param.syntax().text_range(), replacement_text))
}
@ -2124,7 +2119,6 @@ impl<'a> Foo<'a> {
#[test]
fn test_self_outside_of_methods() {
cov_mark::check!(rename_self_outside_of_methods);
check(
"foo",
r#"
@ -2133,7 +2127,7 @@ fn f($0self) -> i32 {
}
"#,
r#"
fn f(foo: _) -> i32 {
fn f(foo: Self) -> i32 {
foo.i
}
"#,