From a0bc236adf8f20ebd0e68bb29986ceca7ef1f6a2 Mon Sep 17 00:00:00 2001 From: Levente Gyozo Lenart Date: Wed, 14 Jul 2021 18:15:00 +0200 Subject: [PATCH 1/2] Add true and false as completion suggestions when expecting an expression --- crates/ide_completion/src/completions/keyword.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crates/ide_completion/src/completions/keyword.rs b/crates/ide_completion/src/completions/keyword.rs index aabc096e6c..c139734fe0 100644 --- a/crates/ide_completion/src/completions/keyword.rs +++ b/crates/ide_completion/src/completions/keyword.rs @@ -105,6 +105,8 @@ pub(crate) fn complete_expr_keyword(acc: &mut Completions, ctx: &CompletionConte add_keyword("if", "if $1 {\n $0\n}"); add_keyword("if let", "if let $1 = $2 {\n $0\n}"); add_keyword("for", "for $1 in $2 {\n $0\n}"); + add_keyword("true", "true"); + add_keyword("false", "false"); } if ctx.previous_token_is(T![if]) || ctx.previous_token_is(T![while]) || has_block_expr_parent { From a3f01974549db9b4ab2f2c4f2caa3ff546a30146 Mon Sep 17 00:00:00 2001 From: Levente Gyozo Lenart Date: Wed, 14 Jul 2021 18:16:18 +0200 Subject: [PATCH 2/2] Update tests --- crates/ide_completion/src/completions/keyword.rs | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/crates/ide_completion/src/completions/keyword.rs b/crates/ide_completion/src/completions/keyword.rs index c139734fe0..f4df2d3809 100644 --- a/crates/ide_completion/src/completions/keyword.rs +++ b/crates/ide_completion/src/completions/keyword.rs @@ -211,6 +211,8 @@ mod tests { kw if kw if let kw for + kw true + kw false kw let kw return kw self @@ -242,6 +244,8 @@ mod tests { kw if kw if let kw for + kw true + kw false kw let kw return kw self @@ -273,6 +277,8 @@ mod tests { kw if kw if let kw for + kw true + kw false kw let kw else kw else if @@ -308,6 +314,8 @@ fn quux() -> i32 { kw if kw if let kw for + kw true + kw false kw return kw self kw super @@ -338,6 +346,8 @@ fn quux() -> i32 { kw if kw if let kw for + kw true + kw false kw let kw continue kw break @@ -432,6 +442,8 @@ fn foo() { kw if kw if let kw for + kw true + kw false kw return kw self kw super @@ -480,6 +492,8 @@ fn foo() { kw if kw if let kw for + kw true + kw false kw return kw self kw super