language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-11-13 09:11:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Never make type mismatch diagnostic stable, even when there is a fix

Browse source 
We show fixes now even for experimental diagnostics anyway, and it has false positives.
This commit is contained in:
Chayim Refael Friedman 2025-06-17 12:48:19 +03:00
parent 2b0c726e1b
commit b46593ece2
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/ide-diagnostics/src/handlers/type_mismatch.rs
View file

@ -39,7 +39,7 @@ pub(crate) fn type_mismatch(ctx: &DiagnosticsContext<'_>, d: &hir::TypeMismatch<
cov_mark::hit!(type_mismatch_range_adjustment); cov_mark::hit!(type_mismatch_range_adjustment);
Some(salient_token_range) Some(salient_token_range)
}); });
let mut diag = Diagnostic::new( Diagnostic::new(
DiagnosticCode::RustcHardError("E0308"), DiagnosticCode::RustcHardError("E0308"),
format!( format!(
"expected {}, found {}", "expected {}, found {}",
@ -52,11 +52,7 @@ pub(crate) fn type_mismatch(ctx: &DiagnosticsContext<'_>, d: &hir::TypeMismatch<
), ),
display_range, display_range,
) )
.with_fixes(fixes(ctx, d)); .with_fixes(fixes(ctx, d))
if diag.fixes.is_some() {
diag.experimental = false;
}
diag
} }
fn fixes(ctx: &DiagnosticsContext<'_>, d: &hir::TypeMismatch<'_>) -> Option<Vec<Assist>> { fn fixes(ctx: &DiagnosticsContext<'_>, d: &hir::TypeMismatch<'_>) -> Option<Vec<Assist>> {