language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-30 05:45:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Do not allocate attributes entry if there are no attributes

Browse source 
This saves 8mb.
This commit is contained in:
Chayim Refael Friedman 2024-10-19 23:07:02 +03:00
parent d0933cc097
commit bccf0062b7
2 changed files with 13 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/hir-def/src/item_tree/lower.rs
View file

@ -198,12 +198,14 @@ impl<'a> Ctx<'a> {
} }
fn add_attrs(&mut self, item: AttrOwner, attrs: RawAttrs) { fn add_attrs(&mut self, item: AttrOwner, attrs: RawAttrs) {
match self.tree.attrs.entry(item) { if !attrs.is_empty() {
Entry::Occupied(mut entry) => { match self.tree.attrs.entry(item) {
*entry.get_mut() = entry.get().merge(attrs); Entry::Occupied(mut entry) => {
} *entry.get_mut() = entry.get().merge(attrs);
Entry::Vacant(entry) => { }
entry.insert(attrs); Entry::Vacant(entry) => {
entry.insert(attrs);
}
} }
} }
} }

5
crates/hir-expand/src/attrs.rs
View file

@ -26,6 +26,7 @@ use crate::{
/// Syntactical attributes, without filtering of `cfg_attr`s. /// Syntactical attributes, without filtering of `cfg_attr`s.
#[derive(Default, Debug, Clone, PartialEq, Eq)] #[derive(Default, Debug, Clone, PartialEq, Eq)]
pub struct RawAttrs { pub struct RawAttrs {
// FIXME: This can become `Box<[Attr]>` if https://internals.rust-lang.org/t/layout-of-dst-box/21728?u=chrefr is accepted.
entries: Option<ThinArc<(), Attr>>, entries: Option<ThinArc<(), Attr>>,
} }
@ -169,6 +170,10 @@ impl RawAttrs {
}; };
RawAttrs { entries } RawAttrs { entries }
} }
pub fn is_empty(&self) -> bool {
self.entries.is_none()
}
} }
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]