mirror of
https://github.com/rust-lang/rust-analyzer.git
synced 2025-09-11 04:46:46 +00:00
Discourage allocation
This commit is contained in:
parent
c87c4a0a40
commit
be0bb857c1
1 changed files with 34 additions and 13 deletions
|
@ -236,11 +236,6 @@ struct Foo {
|
||||||
}
|
}
|
||||||
```
|
```
|
||||||
|
|
||||||
## Documentation
|
|
||||||
|
|
||||||
For `.md` and `.adoc` files, prefer a sentence-per-line format, don't wrap lines.
|
|
||||||
If the line is too long, you want to split the sentence in two :-)
|
|
||||||
|
|
||||||
## Preconditions
|
## Preconditions
|
||||||
|
|
||||||
Function preconditions should generally be expressed in types and provided by the caller (rather than checked by callee):
|
Function preconditions should generally be expressed in types and provided by the caller (rather than checked by callee):
|
||||||
|
@ -261,6 +256,32 @@ fn frobnicate(walrus: Option<Walrus>) {
|
||||||
}
|
}
|
||||||
```
|
```
|
||||||
|
|
||||||
|
## Premature Pessimization
|
||||||
|
|
||||||
|
While we don't specifically optimize code yet, avoid writing the code which is slower than it needs to be.
|
||||||
|
Don't allocate a `Vec` were an iterator would do, don't allocate strings needlessly.
|
||||||
|
|
||||||
|
```rust
|
||||||
|
// Good
|
||||||
|
use itertools::Itertools;
|
||||||
|
|
||||||
|
let (first_word, second_word) = match text.split_ascii_whitespace().collect_tuple() {
|
||||||
|
Some(it) => it,
|
||||||
|
None => return,
|
||||||
|
}
|
||||||
|
|
||||||
|
// Not as good
|
||||||
|
let words = text.split_ascii_whitespace().collect::<Vec<_>>();
|
||||||
|
if words.len() != 2 {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
## Documentation
|
||||||
|
|
||||||
|
For `.md` and `.adoc` files, prefer a sentence-per-line format, don't wrap lines.
|
||||||
|
If the line is too long, you want to split the sentence in two :-)
|
||||||
|
|
||||||
## Commit Style
|
## Commit Style
|
||||||
|
|
||||||
We don't have specific rules around git history hygiene.
|
We don't have specific rules around git history hygiene.
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue