language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-28 10:39:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Merge pull request #19447 from Natural-selection1/add_impl_for

Browse source 
add more completion about "impl"
This commit is contained in:
Lukas Wirth 2025-04-05 13:01:51 +00:00 • committed by GitHub
commit bec545920a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 27 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ide-completion/src/completions/item_list.rs
View file

@ -114,6 +114,7 @@ fn add_keywords(acc: &mut Completions, ctx: &CompletionContext<'_>, kind: Option
add_keyword("trait", "trait $1 {\n $0\n}");
if no_vis_qualifiers {
add_keyword("impl", "impl $1 {\n $0\n}");
add_keyword("impl for", "impl $1 for $2 {\n $0\n}");
}
}
@ -144,6 +145,7 @@ fn add_keywords(acc: &mut Completions, ctx: &CompletionContext<'_>, kind: Option
add_keyword("use", "use $0");
if no_vis_qualifiers {
add_keyword("impl", "impl $1 {\n $0\n}");
add_keyword("impl for", "impl $1 for $2 {\n $0\n}");
}
}

1
crates/ide-completion/src/completions/keyword.rs
View file

@ -56,6 +56,7 @@ mod tests {
kw extern
kw fn
kw impl
kw impl for
kw trait
"#]],
);

14
crates/ide-completion/src/tests/expression.rs
View file

@ -171,6 +171,7 @@ impl Unit {
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -249,6 +250,7 @@ fn complete_in_block() {
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -300,6 +302,7 @@ fn complete_after_if_expr() {
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -375,6 +378,7 @@ fn completes_in_loop_ctx() {
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -961,6 +965,7 @@ fn foo() { if foo {} $0 }
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -1003,6 +1008,7 @@ fn foo() { if foo {} el$0 }
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -1095,6 +1101,7 @@ fn foo() { if foo {} $0 let x = 92; }
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -1137,6 +1144,7 @@ fn foo() { if foo {} el$0 let x = 92; }
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -1179,6 +1187,7 @@ fn foo() { if foo {} el$0 { let x = 92; } }
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -1231,6 +1240,7 @@ pub struct UnstableThisShouldNotBeListed;
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -1285,6 +1295,7 @@ pub struct UnstableButWeAreOnNightlyAnyway;
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -1529,6 +1540,7 @@ fn main() {
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -2001,6 +2013,7 @@ fn bar() {
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -2073,6 +2086,7 @@ fn foo() {
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop

1
crates/ide-completion/src/tests/item.rs
View file

@ -284,6 +284,7 @@ fn bar() {
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop

5
crates/ide-completion/src/tests/item_list.rs
View file

@ -16,6 +16,7 @@ fn in_mod_item_list() {
kw extern
kw fn
kw impl
kw impl for
kw mod
kw pub
kw pub(crate)
@ -50,6 +51,7 @@ fn in_source_file_item_list() {
kw extern
kw fn
kw impl
kw impl for
kw mod
kw pub
kw pub(crate)
@ -83,6 +85,7 @@ fn in_item_list_after_attr() {
kw extern
kw fn
kw impl
kw impl for
kw mod
kw pub
kw pub(crate)
@ -122,6 +125,7 @@ fn after_unsafe_token() {
kw extern
kw fn
kw impl
kw impl for
kw trait
"#]],
);
@ -385,6 +389,7 @@ fn after_unit_struct() {
kw extern
kw fn
kw impl
kw impl for
kw mod
kw pub
kw pub(crate)

4
crates/ide-completion/src/tests/special.rs
View file

@ -1008,6 +1008,7 @@ fn here_we_go() {
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -1059,6 +1060,7 @@ fn here_we_go() {
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -1184,6 +1186,7 @@ fn bar() { qu$0 }
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop
@ -1441,6 +1444,7 @@ fn foo() {
kw if
kw if let
kw impl
kw impl for
kw let
kw letm
kw loop