diff --git a/crates/ra_ide/src/snapshots/highlight_injection.html b/crates/ra_ide/src/snapshots/highlight_injection.html new file mode 100644 index 0000000000..6ec13bd80f --- /dev/null +++ b/crates/ra_ide/src/snapshots/highlight_injection.html @@ -0,0 +1,39 @@ + + +
fn fixture(ra_fixture: &str) {}
+
+fn main() {
+ fixture(r#"
+ trait Foo {
+ fn foo() {
+ println!("2 + 2 = {}", 4);
+ }
+ }"#
+ );
+}
\ No newline at end of file
diff --git a/crates/ra_ide/src/snapshots/highlighting.html b/crates/ra_ide/src/snapshots/highlighting.html
index 495b07f690..214dcbb620 100644
--- a/crates/ra_ide/src/snapshots/highlighting.html
+++ b/crates/ra_ide/src/snapshots/highlighting.html
@@ -26,7 +26,7 @@ pre { color: #DCDCCC; background: #3F3F3F; font-size: 22px; padd
.keyword.unsafe { color: #BC8383; font-weight: bold; }
.control { font-style: italic; }
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug)]
struct Foo {
pub x: i32,
pub y: i32,
@@ -36,11 +36,11 @@ pre { color: #DCDCCC; background: #3F3F3F; font-size: 22px; padd
foo::<'a, i32>()
}
-macro_rules! def_fn {
+macro_rules! def_fn {
($($tt:tt)*) => {$($tt)*}
}
-def_fn! {
+def_fn! {
fn bar() -> u32 {
100
}
@@ -48,7 +48,7 @@ pre { color: #DCDCCC; background: #3F3F3F; font-size: 22px; padd
// comment
fn main() {
- println!("Hello, {}!", 92);
+ println!("Hello, {}!", 92);
let mut vec = Vec::new();
if true {
@@ -73,7 +73,7 @@ pre { color: #DCDCCC; background: #3F3F3F; font-size: 22px; padd
impl<T> Option<T> {
fn and<U>(self, other: Option<U>) -> Option<(T, U)> {
match other {
- None => unimplemented!(),
+ None => unimplemented!(),
Nope => Nope,
}
}
diff --git a/crates/ra_ide/src/syntax_highlighting.rs b/crates/ra_ide/src/syntax_highlighting.rs
index eb1c54639d..7d908f987a 100644
--- a/crates/ra_ide/src/syntax_highlighting.rs
+++ b/crates/ra_ide/src/syntax_highlighting.rs
@@ -174,7 +174,13 @@ pub(crate) fn highlight(
}
assert_eq!(res.len(), 1, "after DFS traversal, the stack should only contain a single element");
- res.pop().unwrap()
+ let res = res.pop().unwrap();
+ // Check that ranges are sorted and disjoint
+ assert!(res
+ .iter()
+ .zip(res.iter().skip(1))
+ .all(|(left, right)| left.range.end() <= right.range.start()));
+ res
}
fn macro_call_range(macro_call: &ast::MacroCall) -> Option {
diff --git a/crates/ra_ide/src/syntax_highlighting/html.rs b/crates/ra_ide/src/syntax_highlighting/html.rs
index e13766c9da..4496529a10 100644
--- a/crates/ra_ide/src/syntax_highlighting/html.rs
+++ b/crates/ra_ide/src/syntax_highlighting/html.rs
@@ -1,9 +1,9 @@
//! Renders a bit of code as HTML.
use ra_db::SourceDatabase;
-use ra_syntax::AstNode;
+use ra_syntax::{AstNode, TextUnit};
-use crate::{FileId, HighlightedRange, RootDatabase};
+use crate::{FileId, RootDatabase};
use super::highlight;
@@ -21,51 +21,35 @@ pub(crate) fn highlight_as_html(db: &RootDatabase, file_id: FileId, rainbow: boo
)
}
- let mut ranges = highlight(db, file_id, None);
- ranges.sort_by_key(|it| it.range.start());
- // quick non-optimal heuristic to intersect token ranges and highlighted ranges
- let mut frontier = 0;
- let mut could_intersect: Vec<&HighlightedRange> = Vec::new();
-
+ let ranges = highlight(db, file_id, None);
+ let text = parse.tree().syntax().to_string();
+ let mut prev_pos = TextUnit::from(0);
let mut buf = String::new();
buf.push_str(&STYLE);
buf.push_str("");
- let tokens = parse.tree().syntax().descendants_with_tokens().filter_map(|it| it.into_token());
- for token in tokens {
- could_intersect.retain(|it| token.text_range().start() <= it.range.end());
- while let Some(r) = ranges.get(frontier) {
- if r.range.start() <= token.text_range().end() {
- could_intersect.push(r);
- frontier += 1;
- } else {
- break;
- }
- }
- let text = html_escape(&token.text());
- let ranges = could_intersect
- .iter()
- .filter(|it| token.text_range().is_subrange(&it.range))
- .collect::>();
- if ranges.is_empty() {
+ for range in &ranges {
+ if range.range.start() > prev_pos {
+ let curr = &text[prev_pos.to_usize()..range.range.start().to_usize()];
+ let text = html_escape(curr);
buf.push_str(&text);
- } else {
- let classes = ranges
- .iter()
- .map(|it| it.highlight.to_string().replace('.', " "))
- .collect::>()
- .join(" ");
- let binding_hash = ranges.first().and_then(|x| x.binding_hash);
- let color = match (rainbow, binding_hash) {
- (true, Some(hash)) => format!(
- " data-binding-hash=\"{}\" style=\"color: {};\"",
- hash,
- rainbowify(hash)
- ),
- _ => "".into(),
- };
- buf.push_str(&format!("{}", classes, color, text));
}
+ let curr = &text[range.range.start().to_usize()..range.range.end().to_usize()];
+
+ let class = range.highlight.to_string().replace('.', " ");
+ let color = match (rainbow, range.binding_hash) {
+ (true, Some(hash)) => {
+ format!(" data-binding-hash=\"{}\" style=\"color: {};\"", hash, rainbowify(hash))
+ }
+ _ => "".into(),
+ };
+ buf.push_str(&format!("{}", class, color, html_escape(curr)));
+
+ prev_pos = range.range.end();
}
+ // Add the remaining (non-highlighted) text
+ let curr = &text[prev_pos.to_usize()..];
+ let text = html_escape(curr);
+ buf.push_str(&text);
buf.push_str("
");
buf
}
diff --git a/crates/ra_ide/src/syntax_highlighting/tests.rs b/crates/ra_ide/src/syntax_highlighting/tests.rs
index 7f442bd0fe..110887c2ac 100644
--- a/crates/ra_ide/src/syntax_highlighting/tests.rs
+++ b/crates/ra_ide/src/syntax_highlighting/tests.rs
@@ -134,16 +134,25 @@ fn test_ranges() {
#[test]
fn test_flattening() {
- let (analysis, file_id) = single_file(r#"#[cfg(feature = "foo")]"#);
+ let (analysis, file_id) = single_file(
+ r##"
+fn fixture(ra_fixture: &str) {}
- let highlights = analysis.highlight(file_id).unwrap();
+fn main() {
+ fixture(r#"
+ trait Foo {
+ fn foo() {
+ println!("2 + 2 = {}", 4);
+ }
+ }"#
+ );
+}"##
+ .trim(),
+ );
- // The source code snippet contains 2 nested highlights:
- // 1) Attribute spanning the whole string
- // 2) The string "foo"
- // The resulting flattening splits the attribute range:
- assert_eq!(highlights.len(), 3);
- assert_eq!(&highlights[0].highlight.to_string(), "attribute");
- assert_eq!(&highlights[1].highlight.to_string(), "string_literal");
- assert_eq!(&highlights[2].highlight.to_string(), "attribute");
+ let dst_file = project_dir().join("crates/ra_ide/src/snapshots/highlight_injection.html");
+ let actual_html = &analysis.highlight_as_html(file_id, false).unwrap();
+ let expected_html = &read_text(&dst_file);
+ fs::write(dst_file, &actual_html).unwrap();
+ assert_eq_text!(expected_html, actual_html);
}