streamline API

crates/ra_syntax/src/algo.rs

@@ -5,16 +5,9 @@ use std::ops::RangeInclusive;
 use itertools::Itertools;
 
 use crate::{
-    AstNode, Direction, NodeOrToken, SourceFile, SyntaxElement, SyntaxNode, SyntaxNodePtr,
-    SyntaxToken, TextRange, TextUnit,
+    AstNode, Direction, NodeOrToken, SyntaxElement, SyntaxNode, SyntaxNodePtr, TextRange, TextUnit,
 };
 
-pub use rowan::TokenAtOffset;
-
-pub fn find_token_at_offset(node: &SyntaxNode, offset: TextUnit) -> TokenAtOffset<SyntaxToken> {
-    node.token_at_offset(offset)
-}
-
 /// Returns ancestors of the node at the offset, sorted by length. This should
 /// do the right thing at an edge, e.g. when searching for expressions at `{
 /// <|>foo }` we will get the name reference instead of the whole block, which
@@ -24,7 +17,7 @@ pub fn ancestors_at_offset(
     node: &SyntaxNode,
     offset: TextUnit,
 ) -> impl Iterator<Item = SyntaxNode> {
-    find_token_at_offset(node, offset)
+    node.token_at_offset(offset)
         .map(|token| token.parent().ancestors())
         .kmerge_by(|node1, node2| node1.text_range().len() < node2.text_range().len())
 }
@@ -137,14 +130,14 @@ fn with_children(
     let len = new_children.iter().map(|it| it.text_len()).sum::<TextUnit>();
     let new_node =
         rowan::GreenNode::new(rowan::cursor::SyntaxKind(parent.kind() as u16), new_children);
-    let new_file_node = parent.replace_with(new_node);
-    let file = SourceFile::new(new_file_node);
+    let new_root_node = parent.replace_with(new_node);
+    let new_root_node = SyntaxNode::new_root(new_root_node);
 
     // FIXME: use a more elegant way to re-fetch the node (#1185), make
     // `range` private afterwards
     let mut ptr = SyntaxNodePtr::new(parent);
     ptr.range = TextRange::offset_len(ptr.range().start(), len);
-    ptr.to_node(file.syntax()).to_owned()
+    ptr.to_node(&new_root_node)
 }
 
 fn position_of_child(parent: &SyntaxNode, child: SyntaxElement) -> usize {

crates/ra_syntax/src/lib.rs

@@ -44,12 +44,10 @@ pub use crate::{
     syntax_error::{Location, SyntaxError, SyntaxErrorKind},
     syntax_node::{
         Direction, NodeOrToken, SyntaxElement, SyntaxNode, SyntaxToken, SyntaxTreeBuilder,
-        WalkEvent,
     },
 };
-pub use ra_parser::SyntaxKind;
-pub use ra_parser::T;
-pub use rowan::{SmolStr, SyntaxText, TextRange, TextUnit};
+pub use ra_parser::{SyntaxKind, T};
+pub use rowan::{SmolStr, SyntaxText, TextRange, TextUnit, TokenAtOffset, WalkEvent};
 
 /// `Parse` is the result of the parsing: a syntax tree and a collection of
 /// errors.

crates/ra_syntax/src/syntax_node.rs

@@ -14,7 +14,6 @@ use crate::{
     Parse, SmolStr, SyntaxKind, TextUnit,
 };
 
-pub use rowan::WalkEvent;
 pub(crate) use rowan::{GreenNode, GreenToken};
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)]