language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-27 12:29:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix on-type offset

Browse source
This commit is contained in:
Aleksey Kladov 2019-01-11 15:05:40 +03:00
parent 4aa632761f
commit d9e70e3160
1 changed files with 21 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

47
crates/ra_lsp_server/src/main_loop/handlers.rs
View file

@ -9,7 +9,7 @@ use languageserver_types::{
SignatureInformation, SymbolInformation, TextDocumentIdentifier, TextEdit, WorkspaceEdit, SignatureInformation, SymbolInformation, TextDocumentIdentifier, TextEdit, WorkspaceEdit,
}; };
use ra_ide_api::{ use ra_ide_api::{
FileId, FilePosition, FileRange, FoldKind, Query, RunnableKind, Severity, SourceChange, FileId, FilePosition, FileRange, FoldKind, Query, RunnableKind, Severity,
}; };
use ra_syntax::{TextUnit, AstNode}; use ra_syntax::{TextUnit, AstNode};
use rustc_hash::FxHashMap; use rustc_hash::FxHashMap;
@ -92,35 +92,30 @@ pub fn handle_on_type_formatting(
world: ServerWorld, world: ServerWorld,
params: req::DocumentOnTypeFormattingParams, params: req::DocumentOnTypeFormattingParams,
) -> Result<Option<Vec<TextEdit>>> { ) -> Result<Option<Vec<TextEdit>>> {
let analysis: Option<Box<Fn(FilePosition) -> Option<SourceChange>>> = match params.ch.as_str() { let file_id = params.text_document.try_conv_with(&world)?;
"=" => Some(Box::new(|pos| world.analysis().on_eq_typed(pos))), let line_index = world.analysis().file_line_index(file_id);
"." => Some(Box::new(|pos| world.analysis().on_dot_typed(pos))), let position = FilePosition {
_ => None, file_id,
/// in `ra_ide_api`, the `on_type` invariant is that
/// `text.char_at(position) == typed_char`.
offset: params.position.conv_with(&line_index) - TextUnit::of_char('.'),
}; };
if let Some(ana) = analysis { let edit = match params.ch.as_str() {
let file_id = params.text_document.try_conv_with(&world)?; "=" => world.analysis().on_eq_typed(position),
let line_index = world.analysis().file_line_index(file_id); "." => world.analysis().on_dot_typed(position),
let position = FilePosition { _ => return Ok(None),
file_id, };
offset: params.position.conv_with(&line_index), let mut edit = match edit {
}; Some(it) => it,
None => return Ok(None),
};
if let Some(mut action) = ana(position) { // This should be a single-file edit
let change: Vec<TextEdit> = action let edit = edit.source_file_edits.pop().unwrap();
.source_file_edits
.pop()
.unwrap()
.edit
.as_atoms()
.iter()
.map_conv_with(&line_index)
.collect();
return Ok(Some(change));
}
}
return Ok(None); let change: Vec<TextEdit> = edit.edit.conv_with(&line_index);
return Ok(Some(change));
} }
pub fn handle_document_symbol( pub fn handle_document_symbol(