language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-11-01 20:31:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(ide-assists): remove AssistKind::None

Browse source 
This was being used by a single assist, which qualifies under the "refactor"
kind. The variant has been removed, and all usages updated accordingly.

Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
This commit is contained in:
Prajwal S N 2025-04-03 14:29:02 +05:30
parent c7845a6d70
commit e02d76aa61
No known key found for this signature in database
GPG key ID: 60701A603988FAC2
5 changed files with 5 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/ide-db/src/assists.rs
View file

@ -43,9 +43,6 @@ pub enum Command {
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum AssistKind {
// FIXME: does the None variant make sense? Probably not.
None,
QuickFix,
Generate,
Refactor,
@ -61,7 +58,7 @@ impl AssistKind {
}
match self {
AssistKind::None | AssistKind::Generate => true,
AssistKind::Generate => true,
AssistKind::Refactor => matches!(
other,
AssistKind::RefactorExtract
@ -74,7 +71,6 @@ impl AssistKind {
pub fn name(&self) -> &str {
match self {
AssistKind::None => "None",
AssistKind::QuickFix => "QuickFix",
AssistKind::Generate => "Generate",
AssistKind::Refactor => "Refactor",
@ -90,7 +86,6 @@ impl FromStr for AssistKind {
fn from_str(s: &str) -> Result<Self, Self::Err> {
match s {
"None" => Ok(AssistKind::None),
"QuickFix" => Ok(AssistKind::QuickFix),
"Generate" => Ok(AssistKind::Generate),
"Refactor" => Ok(AssistKind::Refactor),
@ -108,10 +103,6 @@ impl FromStr for AssistKind {
pub struct AssistId(pub &'static str, pub AssistKind, pub Option<usize>);
impl AssistId {
pub fn none(id: &'static str) -> AssistId {
AssistId(id, AssistKind::None, None)
}
pub fn quick_fix(id: &'static str) -> AssistId {
AssistId(id, AssistKind::QuickFix, None)
}