mirror of
https://github.com/rust-lang/rust-analyzer.git
synced 2025-10-26 09:49:15 +00:00
update blocklike
This commit is contained in:
parent
11717ca5d4
commit
e3deeec2f2
5 changed files with 10 additions and 13 deletions
|
|
@ -12,7 +12,7 @@ use crate::{
|
|||
/// `Parser` produces a flat list of `Event`s.
|
||||
/// They are converted to a tree-structure in
|
||||
/// a separate pass, via `TreeBuilder`.
|
||||
#[derive(Debug)]
|
||||
#[derive(Debug, PartialEq)]
|
||||
pub(crate) enum Event {
|
||||
/// This event signifies the start of the node.
|
||||
/// It should be either abandoned (in which case the
|
||||
|
|
|
|||
|
|
@ -204,8 +204,9 @@ impl BlockLike {
|
|||
self == BlockLike::Block
|
||||
}
|
||||
|
||||
fn is_blocklike(kind: SyntaxKind) -> bool {
|
||||
matches!(kind, BLOCK_EXPR | IF_EXPR | WHILE_EXPR | FOR_EXPR | LOOP_EXPR | MATCH_EXPR)
|
||||
fn is_blocklike(expr: &CompletedMarker, p: &Parser<'_>) -> bool {
|
||||
matches!(expr.kind(), BLOCK_EXPR | IF_EXPR | WHILE_EXPR | FOR_EXPR | LOOP_EXPR | MATCH_EXPR)
|
||||
|| (expr.last_token(p) == Some(T!['}']) && !matches!(expr.kind(), CLOSURE_EXPR))
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -134,12 +134,10 @@ pub(super) fn let_stmt(p: &mut Parser<'_>, with_semi: Semicolon) {
|
|||
// test_err let_else_right_curly_brace
|
||||
// fn func() { let Some(_) = {Some(1)} else { panic!("h") };}
|
||||
if let Some(expr) = expr_after_eq {
|
||||
if let Some(token) = expr.last_token(p) {
|
||||
if token == T!['}'] {
|
||||
p.error(
|
||||
"right curly brace `}` before `else` in a `let...else` statement not allowed"
|
||||
)
|
||||
}
|
||||
if BlockLike::is_blocklike(&expr, p) {
|
||||
p.error(
|
||||
"right curly brace `}` before `else` in a `let...else` statement not allowed",
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -198,7 +198,7 @@ pub(super) fn atom_expr(
|
|||
}
|
||||
};
|
||||
let blocklike =
|
||||
if BlockLike::is_blocklike(done.kind()) { BlockLike::Block } else { BlockLike::NotBlock };
|
||||
if BlockLike::is_blocklike(&done, p) { BlockLike::Block } else { BlockLike::NotBlock };
|
||||
Some((done, blocklike))
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -391,9 +391,7 @@ impl CompletedMarker {
|
|||
|
||||
pub(crate) fn last_token(&self, p: &Parser<'_>) -> Option<SyntaxKind> {
|
||||
let end_pos = self.end_pos as usize;
|
||||
if end_pos > p.events.len() {
|
||||
return None;
|
||||
}
|
||||
debug_assert_eq!(p.events[end_pos - 1], Event::Finish);
|
||||
p.events[..end_pos].iter().rev().find_map(|event| match event {
|
||||
Event::Token { kind, .. } => Some(*kind),
|
||||
_ => None,
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue