language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-03 15:15:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Merge #2839

Browse source 
2839: Tweak add_custom_impl r=matklad a=kjeremy

Display a nicer label and categorize

Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
This commit is contained in:
bors[bot] 2020-01-14 14:27:58 +00:00 • committed by GitHub
commit e406f2bed6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/ra_assists/src/assists/add_custom_impl.rs
View file

@ -49,7 +49,10 @@ pub(crate) fn add_custom_impl(ctx: AssistCtx<impl HirDatabase>) -> Option<Assist
let annotated_name = annotated.syntax().text().to_string(); let annotated_name = annotated.syntax().text().to_string();
let start_offset = annotated.syntax().parent()?.text_range().end(); let start_offset = annotated.syntax().parent()?.text_range().end();
ctx.add_assist(AssistId("add_custom_impl"), "add custom impl", |edit| { let label =
format!("Add Custom impl '{}' for '{}'", trait_token.text().as_str(), annotated_name);
ctx.add_assist(AssistId("add_custom_impl"), label, |edit| {
edit.target(attr.syntax().text_range()); edit.target(attr.syntax().text_range());
let new_attr_input = input let new_attr_input = input

1
crates/ra_lsp_server/src/main_loop/handlers.rs
View file

@ -710,6 +710,7 @@ pub fn handle_code_action(
title: command.title.clone(), title: command.title.clone(),
kind: match assist.id { kind: match assist.id {
AssistId("introduce_variable") => Some("refactor.extract.variable".to_string()), AssistId("introduce_variable") => Some("refactor.extract.variable".to_string()),
AssistId("add_custom_impl") => Some("refactor.rewrite.add_custom_impl".to_string()),
_ => None, _ => None,
}, },
diagnostics: None, diagnostics: None,