language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-02 06:41:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Complete associated types in dyn and impl trait

Browse source
This commit is contained in:
Lukas Wirth 2021-06-11 23:12:30 +02:00
parent 863e23f00f
commit ec9ef9c283
4 changed files with 64 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

23
crates/ide_completion/src/render/type_alias.rs
View file

@ -16,7 +16,14 @@ pub(crate) fn render_type_alias<'a>(
ctx: RenderContext<'a>,
type_alias: hir::TypeAlias,
) -> Option<CompletionItem> {
TypeAliasRender::new(ctx, type_alias)?.render()
TypeAliasRender::new(ctx, type_alias)?.render(false)
}
pub(crate) fn render_type_alias_with_eq<'a>(
ctx: RenderContext<'a>,
type_alias: hir::TypeAlias,
) -> Option<CompletionItem> {
TypeAliasRender::new(ctx, type_alias)?.render(true)
}
#[derive(Debug)]
@ -32,8 +39,14 @@ impl<'a> TypeAliasRender<'a> {
Some(TypeAliasRender { ctx, type_alias, ast_node })
}
fn render(self) -> Option<CompletionItem> {
let name = self.name()?;
fn render(self, with_eq: bool) -> Option<CompletionItem> {
let name = self.ast_node.name().map(|name| {
if with_eq {
format!("{} = ", name.text())
} else {
name.text().to_string()
}
})?;
let detail = self.detail();
let mut item =
@ -49,10 +62,6 @@ impl<'a> TypeAliasRender<'a> {
Some(item.build())
}
fn name(&self) -> Option<String> {
self.ast_node.name().map(|name| name.text().to_string())
}
fn detail(&self) -> String {
type_label(&self.ast_node)
}