language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-26 11:59:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

SCIP: Qualify parameters by the containing function

Browse source 
SCIP requires symbols to be unique, but multiple functions may have a
parameter with the same name. Qualify parameters according to the
containing function.
This commit is contained in:
Wilfred Hughes 2023-08-04 15:28:22 -07:00
parent c59bd2dc3f
commit edabffbd5a
2 changed files with 49 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/ide/src/moniker.rs
View file

@ -177,6 +177,17 @@ pub(crate) fn def_to_moniker(
});
}
// Qualify locals/parameters by their parent definition name.
if let Definition::Local(it) = def {
let parent_name = it.parent(db).name(db);
if let Some(name) = parent_name {
description.push(MonikerDescriptor {
name: name.display(db).to_string(),
desc: MonikerDescriptorKind::Method,
});
}
}
let name_desc = match def {
// These are handled by top-level guard (for performance).
Definition::GenericParam(_)