language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-27 12:29:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Use bitflags to compress function properties

Browse source 
Very minor savings, only 1 MB or so
This commit is contained in:
Jonas Schievink 2021-04-03 20:58:42 +02:00
parent f7e6b186e1
commit ee4b5a34d8
11 changed files with 120 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/hir/src/display.rs
View file

@ -20,22 +20,21 @@ impl HirDisplay for Function {
fn hir_fmt(&self, f: &mut HirFormatter) -> Result<(), HirDisplayError> {
let data = f.db.function_data(self.id);
write_visibility(self.module(f.db).id, self.visibility(f.db), f)?;
let qual = &data.qualifier;
if qual.is_default {
if data.is_default() {
write!(f, "default ")?;
}
if qual.is_const {
if data.is_const() {
write!(f, "const ")?;
}
if qual.is_async {
if data.is_async() {
write!(f, "async ")?;
}
if qual.is_unsafe {
if data.is_unsafe() {
write!(f, "unsafe ")?;
}
if let Some(abi) = &qual.abi {
if let Some(abi) = &data.abi {
// FIXME: String escape?
write!(f, "extern \"{}\" ", abi)?;
write!(f, "extern \"{}\" ", &**abi)?;
}
write!(f, "fn {}", data.name)?;
@ -68,7 +67,7 @@ impl HirDisplay for Function {
write!(f, ", ")?;
} else {
first = false;
if data.has_self_param {
if data.has_self_param() {
write_self_param(type_ref, f)?;
continue;
}
@ -88,7 +87,7 @@ impl HirDisplay for Function {
// `FunctionData::ret_type` will be `::core::future::Future<Output = ...>` for async fns.
// Use ugly pattern match to strip the Future trait.
// Better way?
let ret_type = if !qual.is_async {
let ret_type = if !data.is_async() {
&data.ret_type
} else {
match &*data.ret_type {