language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-30 05:45:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Check that impl self type matches up with expected self type in path mode

Browse source 
Fixes #3144.
This commit is contained in:
Florian Diebold 2020-02-14 21:08:25 +01:00
parent 1ead9ef13b
commit f47dc4de8d
3 changed files with 42 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/ra_hir_ty/src/method_resolution.rs
View file

@ -425,6 +425,15 @@ fn iterate_inherent_methods<T>(
if !is_valid_candidate(db, name, receiver_ty, item, self_ty) {
continue;
}
// we have to check whether the self type unifies with the type
// that the impl is for. If we have a receiver type, this
// already happens in `is_valid_candidate` above; if not, we
// check it here
if receiver_ty.is_none() && inherent_impl_substs(db, impl_block, self_ty).is_none()
{
test_utils::tested_by!(impl_self_type_match_without_receiver);
continue;
}
if let Some(result) = callback(&self_ty.value, item) {
return Some(result);
}