language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-29 05:15:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Deprioritize ops function completions for non-method calls

Browse source
This commit is contained in:
Lukas Wirth 2022-02-01 12:33:55 +01:00
parent 4800c05a20
commit fcdced115e
2 changed files with 30 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
crates/ide_completion/src/render/function.rs
View file

@ -67,16 +67,14 @@ fn render(
);
let ret_type = func.ret_type(db);
let is_op_method = func
.as_assoc_item(ctx.db())
.and_then(|trait_| trait_.containing_trait_or_trait_impl(ctx.db()))
.map_or(false, |trait_| completion.is_ops_trait(trait_));
item.set_relevance(CompletionRelevance {
type_match: compute_type_match(completion, &ret_type),
exact_name_match: compute_exact_name_match(completion, &call),
is_op_method: match func_type {
FuncType::Method(_) => func
.as_assoc_item(ctx.db())
.and_then(|trait_| trait_.containing_trait_or_trait_impl(ctx.db()))
.map_or(false, |trait_| completion.is_ops_trait(trait_)),
_ => false,
},
is_op_method,
..CompletionRelevance::default()
});