A4-Tacks
07f33e2b81
Fix IfExpr then branch suggest
...
- And add logic operation suggest
Example
---
In the old implementation, it always suggested conditions,
this is a lot of noise, e.g `contract_checks()~(use std::intrinsics::contract_checks) const fn() -> bool`
```rust
fn foo() {
if true {
c$0
}
}
```
2025-09-20 20:56:27 +08:00
Shoyu Vanilla (Flint)
259a01d73d
Merge pull request #20688 from A4-Tacks/fix-applicable-after-l-curly-replace-is-method-with-if-let
...
Fix applicable after l_curly for replace_is_method_with_if_let_method
2025-09-20 12:06:18 +00:00
Shoyu Vanilla (Flint)
84bb4051bf
Merge pull request #20700 from A4-Tacks/extract-var-let-expr
...
Fix extract_variable on LetExpr
2025-09-20 11:59:20 +00:00
Shoyu Vanilla (Flint)
a943034d68
Merge pull request #20702 from A4-Tacks/else-not-before-else
...
Fix `else` completion before else keyword
2025-09-20 11:57:07 +00:00
Shoyu Vanilla (Flint)
81ea457fc5
Merge pull request #20708 from A4-Tacks/destruct-ref-mut-panics
...
Fix panics on `Foo{mut x}` for destructure_struct_binding
2025-09-20 11:54:47 +00:00
A4-Tacks
d4731ad9e2
Fix panics on Foo{mut x}
for destructure_struct_binding
...
Example
---
```rust
struct Foo { x: () }
struct Bar { foo: Foo }
fn f(Bar { mut $0foo }: Bar) {}
```
**Before this PR**:
Panic `Option::unwrap`
**After this PR**:
```rust
struct Foo { x: () }
struct Bar { foo: Foo }
fn f(Bar { foo: Foo { mut x } }: Bar) {}
```
2025-09-20 16:14:51 +08:00
Laurențiu Nicola
4599670308
Bump rustc crates once more
2025-09-20 09:38:53 +03:00
Chayim Refael Friedman
b12a129347
Merge pull request #20701 from A4-Tacks/track-caller-assist-test
...
metrics / build_metrics (push) Waiting to run
metrics / other_metrics (diesel-1.4.8) (push) Blocked by required conditions
metrics / other_metrics (hyper-0.14.18) (push) Blocked by required conditions
metrics / other_metrics (ripgrep-13.0.0) (push) Blocked by required conditions
metrics / other_metrics (self) (push) Blocked by required conditions
metrics / other_metrics (webrender-2022) (push) Blocked by required conditions
metrics / generate_final_metrics (push) Blocked by required conditions
rustdoc / rustdoc (push) Waiting to run
Add `#[track_caller]` for check_assist_by_label
2025-09-19 15:07:17 +00:00
Shoyu Vanilla (Flint)
2c6f0fc0df
Merge pull request #20697 from Oblarg/fix-negative-const-generic-literals
...
fix negative const generic integer literals
2025-09-19 14:13:54 +00:00
Oblarg
30031b84a8
address review feedback
2025-09-19 10:03:14 -04:00
Shoyu Vanilla
3b4f5fbd73
minor: Get rid of unused deps chalk-solve
and chalk-recursive
2025-09-19 22:35:46 +09:00
A4-Tacks
c976f9900d
Fix else
completion before else keyword
...
Example
---
```rust
fn foo() {
let x = if true {
1
} el$0 else {
2
};
}
```
**Before this PR**:
```text
else~ k [LS]
else if~ k [LS]
```
**After this PR**:
```text
else if~ k [LS]
```
2025-09-19 19:59:47 +08:00
A4-Tacks
42bba767ef
Add #[track_caller]
for check_assist_by_label
2025-09-19 13:39:45 +08:00
A4-Tacks
3610cb12f7
Fix extract_variable on LetExpr
...
Example
---
```rust
fn main() {
if $0let$0 Some(x) = Some(2+2) {}
}
```
**Before this PR**:
```rust
fn main() {
let $0var_name = let Some(x) = Some(2+2);
if var_name {}
}
```
**After this PR**:
```rust
fn main() {
let $0var_name = Some(2+2);
if let Some(x) = var_name {}
}
```
2025-09-19 13:35:34 +08:00
Laurențiu Nicola
5a643b8158
Set WithCachedTypeInfo::stable_hash when in-tree
2025-09-19 08:08:23 +03:00
Oblarg
d0bdedde0e
fix negative const generic integer literals
2025-09-18 18:55:13 -04:00
Shoyu Vanilla
a04f5185b1
fix: Fix one more thing in in-rust-tree
2025-09-19 04:20:24 +09:00
Laurențiu Nicola
e6c3152214
Merge pull request #20694 from ShoyuVanilla/bump-rustc
...
minor: Yet another rustc crates bump
2025-09-18 18:38:03 +00:00
Shoyu Vanilla
7dfb1c463e
minor: Yet another rustc crates bump
2025-09-19 03:26:03 +09:00
Shoyu Vanilla
c462f99914
fix: Fix indexmap
with in-rust-tree
2025-09-19 03:04:14 +09:00
Laurențiu Nicola
f289a24d0a
Bump rustc crates again
2025-09-18 19:03:35 +03:00
Shoyu Vanilla
74dda38d54
chore: Update rustc deps
2025-09-18 23:02:42 +09:00
A4-Tacks
d3748517c9
Fix applicable after l_curly for replace_is_method_with_if_let_method
2025-09-18 20:00:31 +08:00
Chayim Refael Friedman
cd31e11f94
Merge pull request #20664 from ChayimFriedman2/coerce-ns
...
metrics / other_metrics (hyper-0.14.18) (push) Blocked by required conditions
metrics / build_metrics (push) Waiting to run
metrics / other_metrics (diesel-1.4.8) (push) Blocked by required conditions
metrics / other_metrics (ripgrep-13.0.0) (push) Blocked by required conditions
metrics / other_metrics (self) (push) Blocked by required conditions
metrics / other_metrics (webrender-2022) (push) Blocked by required conditions
metrics / generate_final_metrics (push) Blocked by required conditions
rustdoc / rustdoc (push) Waiting to run
fix: Port a bunch of stuff from rustc and fix a bunch of type mismatches/diagnostics
2025-09-18 00:19:30 +00:00
Shoyu Vanilla (Flint)
2268a56350
Merge pull request #20682 from A4-Tacks/fix-change-vis-applicable-on-variant
...
metrics / build_metrics (push) Waiting to run
metrics / other_metrics (diesel-1.4.8) (push) Blocked by required conditions
metrics / other_metrics (hyper-0.14.18) (push) Blocked by required conditions
metrics / other_metrics (ripgrep-13.0.0) (push) Blocked by required conditions
metrics / other_metrics (self) (push) Blocked by required conditions
metrics / other_metrics (webrender-2022) (push) Blocked by required conditions
metrics / generate_final_metrics (push) Blocked by required conditions
rustdoc / rustdoc (push) Waiting to run
Fix applicable on variant field for change_visibility
2025-09-17 17:00:31 +00:00
A4-Tacks
5b5c50eec8
Fix applicable on variant field for change_visibility
...
Enum variant fields do not allow visibility
Example
---
```rust
enum Foo {
Variant($0String),
}
```
**Before this PR**:
```rust
enum Foo {
Variant(pub(crate) String),
}
```
**After this PR**:
Assist not applicable
2025-09-17 22:57:25 +08:00
Chayim Refael Friedman
5b68439f13
Merge pull request #20583 from btj/comments-enable
...
metrics / build_metrics (push) Waiting to run
metrics / other_metrics (diesel-1.4.8) (push) Blocked by required conditions
metrics / other_metrics (hyper-0.14.18) (push) Blocked by required conditions
metrics / other_metrics (ripgrep-13.0.0) (push) Blocked by required conditions
metrics / other_metrics (self) (push) Blocked by required conditions
metrics / other_metrics (webrender-2022) (push) Blocked by required conditions
metrics / generate_final_metrics (push) Blocked by required conditions
rustdoc / rustdoc (push) Waiting to run
Add `rust-analyzer.semanticHighlighting.comments.enable`
2025-09-17 14:06:17 +00:00
Bart Jacobs
d106d41fbc
Add the rust-analyzer.semanticHighlighting.comments.enable
configuration value
2025-09-17 15:46:23 +02:00
Chayim Refael Friedman
78bb458996
Merge pull request #20379 from skewb1k/fix/consistent-hover-doc-breaks
...
metrics / build_metrics (push) Waiting to run
metrics / other_metrics (diesel-1.4.8) (push) Blocked by required conditions
metrics / other_metrics (hyper-0.14.18) (push) Blocked by required conditions
metrics / other_metrics (ripgrep-13.0.0) (push) Blocked by required conditions
metrics / other_metrics (self) (push) Blocked by required conditions
metrics / other_metrics (webrender-2022) (push) Blocked by required conditions
metrics / generate_final_metrics (push) Blocked by required conditions
rustdoc / rustdoc (push) Waiting to run
fix(hover): unify horizontal rule formatting to `---`
2025-09-17 02:02:48 +00:00
Shoyu Vanilla
0b76080c36
Fix "sync-from-ra" for rust-lang/rust
2025-09-17 03:22:52 +09:00
Lukas Wirth
57ad00b07f
Merge pull request #20612 from Veykril/veykril/push-vzuykrsxvrts
...
metrics / other_metrics (hyper-0.14.18) (push) Blocked by required conditions
metrics / build_metrics (push) Waiting to run
metrics / other_metrics (diesel-1.4.8) (push) Blocked by required conditions
metrics / other_metrics (ripgrep-13.0.0) (push) Blocked by required conditions
metrics / other_metrics (self) (push) Blocked by required conditions
metrics / other_metrics (webrender-2022) (push) Blocked by required conditions
metrics / generate_final_metrics (push) Blocked by required conditions
rustdoc / rustdoc (push) Waiting to run
fix: Fix expand macro recursively not working correctly for nested macro calls
2025-09-16 07:51:08 +00:00
Lukas Wirth
0bbc55b367
Merge pull request #20402 from rust-lang/veykril/push-pursotqxutsx
...
Add more workaround hacks for incorrect startup diagnostics
2025-09-16 07:30:45 +00:00
Lukas Wirth
aecb756876
Merge pull request #20517 from Veykril/veykril/push-wrurmtqppzus
...
fix: Only compute unstable paths on nightly toolchains for IDE features
2025-09-16 07:28:47 +00:00
Lukas Wirth
015b9466c7
Add more workaround hacks for incorrect startup diagnostics
2025-09-16 09:18:03 +02:00
Lukas Wirth
8fcc577b73
Workaround lsp-types typo
2025-09-16 09:17:38 +02:00
Lukas Wirth
685f156fa6
fix: Only compute unstable paths on nightly toolchains for IDE features
2025-09-16 09:17:16 +02:00
Lukas Wirth
bd57ea0871
fix: Fix expand macro recursively not working correctly for nested macro calls
2025-09-16 09:16:42 +02:00
Shoyu Vanilla
33f7ffe4da
fix: More precise clause filtering for explicit_*_predicates_of
2025-09-16 01:44:00 +09:00
Chayim Refael Friedman
7d1860807e
Port a bunch of stuff from rustc and fix a bunch of type mismatches/diagnostics
...
This started from porting coercion, but ended with porting much more.
2025-09-15 18:56:17 +03:00
Chayim Refael Friedman
622b2675db
Merge pull request #20667 from ChayimFriedman2/ns-cleanup2
...
metrics / build_metrics (push) Waiting to run
metrics / other_metrics (diesel-1.4.8) (push) Blocked by required conditions
metrics / other_metrics (hyper-0.14.18) (push) Blocked by required conditions
metrics / other_metrics (ripgrep-13.0.0) (push) Blocked by required conditions
metrics / other_metrics (self) (push) Blocked by required conditions
metrics / other_metrics (webrender-2022) (push) Blocked by required conditions
metrics / generate_final_metrics (push) Blocked by required conditions
rustdoc / rustdoc (push) Waiting to run
internal: Add Regression Test For The One And The Only Issue #5514
2025-09-15 06:02:57 +00:00
Chayim Refael Friedman
b9797aa325
Add Regression Test For The One And The Only Issue #5514
2025-09-15 08:50:41 +03:00
Laurențiu Nicola
6f9a6ba017
Merge pull request #20652 from ChayimFriedman2/cli-diags
...
internal: Improve `rust-analyzer diagnostics`
2025-09-15 05:42:46 +00:00
Shoyu Vanilla (Flint)
3a675445ac
Merge pull request #20665 from ChayimFriedman2/error-notable
...
fix: Don't mark unknown type as implementing every notable trait
2025-09-15 05:39:17 +00:00
Chayim Refael Friedman
40487c6a60
Add regression tests to some S-blocked-on-new-solver issues
...
That were fixed by the migration.
2025-09-15 08:25:17 +03:00
Chayim Refael Friedman
4dbb8b4c64
Don't mark unknown type as implementing every notable trait
...
Because the new solver, will return "yes" for them (which is a good thing).
2025-09-15 07:57:19 +03:00
Chayim Refael Friedman
27897e48dc
Improve rust-analyzer diagnostics
...
In my experience the `processing <module>` messages make it harder to search for the actual diagnostics, so remove them and instead print the filename only if there is a diagnostic.
Also allow choosing the minimum severity.
2025-09-14 23:22:57 +03:00
Chayim Refael Friedman
760d378e4c
Merge pull request #20654 from ShoyuVanilla/predicates
...
metrics / build_metrics (push) Waiting to run
metrics / other_metrics (diesel-1.4.8) (push) Blocked by required conditions
metrics / other_metrics (hyper-0.14.18) (push) Blocked by required conditions
metrics / other_metrics (ripgrep-13.0.0) (push) Blocked by required conditions
metrics / other_metrics (self) (push) Blocked by required conditions
metrics / other_metrics (webrender-2022) (push) Blocked by required conditions
metrics / generate_final_metrics (push) Blocked by required conditions
rustdoc / rustdoc (push) Waiting to run
fix: Infinite loop while elaborting predicates
2025-09-14 11:20:04 +00:00
Shoyu Vanilla
26b8b794fb
fix: Infinite loop while elaborting predicates
2025-09-14 20:08:40 +09:00
Shoyu Vanilla (Flint)
5727ececcc
Merge pull request #20635 from iorizu/fix-double-flycheck
...
fix: Don't trigger two flychecks when saving files that are part of targets
2025-09-14 09:11:30 +00:00
A4-Tacks
d42c81e8d1
Fix extra semicolon before else in let-stmt
...
Example
---
```rust
fn main() {
let x = if true {
()
} $0 else {};
}
```
**Before this PR**:
```rust
fn main() {
let x = if true {
()
} else if $1 {
$0
}; else {};
}
```
**After this PR**:
```rust
fn main() {
let x = if true {
()
} else if $1 {
$0
} else {};
}
```
2025-09-12 20:56:59 +08:00