Lukas Wirth
f37d0fa9d3
Merge pull request #18628 from Veykril/push-sqpymrtxysmw
...
Add typing handler for param list pipe
2024-12-06 15:03:41 +00:00
Giga Bowser
d329329b76
feat: Migrate flip_comma assist to SyntaxEditor
2024-12-06 10:03:09 -05:00
Giga Bowser
8fd7790eb5
minor: Add token_tree constructor to SyntaxFactory
2024-12-06 10:03:09 -05:00
Giga Bowser
d55879d1cb
feat: Migrate flip_trait_bound assist to SyntaxEditor
2024-12-06 10:02:34 -05:00
Giga Bowser
09dee81412
feat: Migrate flip_binexpr assist to SyntaxEditor
2024-12-06 10:02:34 -05:00
Giga Bowser
fbb392062a
minor: Add expr_bin constructor to SyntaxFactory
2024-12-06 10:02:34 -05:00
Giga Bowser
6406048626
minor: Add token constructor to SyntaxFactory
2024-12-06 10:02:34 -05:00
Giga Bowser
5eb8affdc5
fix: Don't produce ChangedAncestor for SyntaxTokens
2024-12-06 10:01:34 -05:00
Giga Bowser
ff1124918e
fix: Properly determine SyntaxEditor replacement intersection
...
Bordering replacements should not be considered intersecting
2024-12-06 10:01:34 -05:00
Lukas Wirth
54dbf1b446
Add typing handler for param list pipe
2024-12-06 15:49:36 +01:00
Lukas Wirth
1b8360be51
Merge pull request #18627 from Veykril/push-tzvnrnytrksr
...
Improve heuristics for on typing semicolon insertion
2024-12-06 14:15:13 +00:00
Lukas Wirth
5dc5107e9c
Improve heuristics for on typing semicolon insertion
2024-12-06 15:00:09 +01:00
Lukas Wirth
4b350f2f11
Merge pull request #18551 from ShoyuVanilla/migrate-turbofish-assist
...
Migrate `add_turbo_fish` to `SyntaxEditor`
2024-12-06 13:44:54 +00:00
Lukas Wirth
c58548e92e
Merge pull request #18563 from alibektas/workspace_key_high_precedence
...
minor: run `FlycheckHandle::restart_workspace` when `check_workspace` true
2024-12-06 13:09:32 +00:00
Lukas Wirth
abc7147bb7
Merge pull request #18594 from ChayimFriedman2/async-closures
...
feat: Support `AsyncFnX` traits
2024-12-06 12:48:47 +00:00
Lukas Wirth
630e4ca44a
Merge pull request #18474 from Veykril/push-nvtxykxkwnvs
...
Make bracket typing handler work on more things
2024-12-06 12:03:52 +00:00
Lukas Wirth
632ca53df4
Merge pull request #18610 from Veykril/push-kynytqktmnxq
...
Add implict unsafety inlay hints for extern blocks
2024-12-06 12:01:49 +00:00
Lukas Wirth
19465b94f5
Add implict unsafety inlay hints for extern blocks
2024-12-06 12:49:03 +01:00
Lukas Wirth
bac0ed579f
Make bracket typing handler work on more things
2024-12-06 12:47:32 +01:00
Lukas Wirth
cddaf7485f
Merge pull request #18625 from Veykril/push-npnxwpxuzlqz
...
fix: Fix parser getting stuck for bad asm expressions
2024-12-06 05:11:08 +00:00
Lukas Wirth
4a24e729b0
fix: Fix parser getting stuck for bad asm expressions
2024-12-06 05:57:00 +01:00
Lukas Wirth
150b0e7292
Merge pull request #18622 from Veykril/push-wlzptrukvyup
...
fix: Fix parsing of dyn T in generic arg on 2015 edition
2024-12-05 19:41:34 +00:00
Lukas Wirth
a049941c1a
fix: Fix parsing of dyn T in generic arg on 2015 edition
2024-12-05 20:26:49 +01:00
David Barsky
5d23772649
Merge pull request #18538 from tareknaser/syntax_factory_sort_items
...
Migrate `sort_items` Assist to Use `SyntaxFactory`
2024-12-05 19:21:51 +00:00
David Barsky
2fd06545a6
Merge pull request #18483 from tareknaser/syntax_factory_introduce_named_generic
...
Migrate `introduce_named_generic` Assist to Use `SyntaxFactory`
2024-12-05 18:42:27 +00:00
Lukas Wirth
d6b62265b5
fix: Resolve generic parameters within use captures
2024-12-05 19:11:33 +01:00
Lukas Wirth
7f39ee3fce
Merge pull request #18620 from Veykril/push-pyulxnouvxkq
...
fix: Parse lifetime bounds in lifetime param into TypeBoundList
2024-12-05 17:06:02 +00:00
Lukas Wirth
f3d7415bd6
Parse lifetime bounds in lifetime param into TypeBoundList
...
This mainly aids in error recovery but also makes it a bit easier to handle lifetime resolution.
While doing so it also came apparent that we were not actually lowering lifetime outlives relationships within lifetime parameter declaration bounds, so this fixes that.
2024-12-05 17:52:02 +01:00
Lukas Wirth
0b5f51a264
Merge pull request #18619 from ShoyuVanilla/issue-18613
...
fix: Panic when displaying generic params with defaults
2024-12-05 16:31:33 +00:00
Shoyu Vanilla
405520150d
fix: Panic when displaying generic params with defaults
2024-12-06 01:10:46 +09:00
Lukas Wirth
4df6dc8f9c
Merge pull request #18618 from Veykril/push-ysklqzomkyvp
...
fix: Fix parsing of integer/keyword name refs in various places
2024-12-05 14:42:00 +00:00
Lukas Wirth
df7ab62a06
fix: Fix parsing of integer/keyword name refs in various places
2024-12-05 15:27:50 +01:00
Tarek
8954a7f9e9
fix: rename syntax_editor_add_generic_param to add_generic_param
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-05 13:50:43 +02:00
Lukas Wirth
e7c8b2fd81
Merge pull request #18616 from Veykril/push-pkumxswtxspo
...
fix: Disable `<` typing handler again
2024-12-05 09:00:46 +00:00
Lukas Wirth
d71e41dba6
Disable < typing handler again
2024-12-05 09:46:23 +01:00
Lukas Wirth
f499faf72b
Merge pull request #18611 from ChayimFriedman2/proc-macro-warn
...
fix: Do not report warnings from proc macros, ever
2024-12-04 16:39:54 +00:00
Oli Scherer
a035c6c3fb
Rename core_pattern_type and core_pattern_types lib feature gates to pattern_type_macro
...
That's what the gates are actually gating, and the single char difference in naming was not helpful either
2024-12-04 16:16:24 +00:00
Tarek
b7e613c0dc
fix: update introduce_named_generic to use type_param directly
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-04 16:02:03 +02:00
Chayim Refael Friedman
33c7e81e90
Do not report warnings from proc macros, ever
2024-12-04 15:25:01 +02:00
Tarek
9157761f5d
refactor: move editing for ast using SyntaxEditor to a separate file
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-04 14:51:48 +02:00
Tarek
2fb563f192
fix: refactor introduce_named_generic assist
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-04 14:50:03 +02:00
Tarek
5aaffe6dc9
fix: correct token type for closing angle bracket
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-04 14:50:03 +02:00
Tarek
70ef2f23c2
fix: refactor syntax_editor_add_generic_param
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-04 14:50:03 +02:00
Tarek
54f7ed13f5
fix: refactor syntax_editor_add_generic_param to handle adding new generic parameters
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-04 14:50:03 +02:00
Tarek
98e10d76ca
fix: refactor syntax_editor_add_generic_param to handle new generic parameters
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-04 14:50:03 +02:00
Tarek
0990d5956d
fix: implement syntax_editor_create_generic_param_list
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-04 14:50:03 +02:00
Tarek
642d4f3385
define syntax_editor_add_generic_param
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-04 14:50:03 +02:00
Tarek
4af3d6f598
fix: remove make_mut from introduce_named_generic assist
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-04 14:50:03 +02:00
Tarek
1400aec433
feat: migrate introduce_named_generic assist to use SyntaxFactory
...
Signed-off-by: Tarek <tareknaser360@gmail.com>
2024-12-04 14:50:03 +02:00
Chayim Refael Friedman
21ad3b5b87
Complete diagnostics in ty lowering groundwork
...
Implement diagnostics in all places left: generics (predicates, defaults, const params' types), fields, and type aliases.
Unfortunately this results in a 20mb addition in `analysis-stats .` due to many type methods returning an addition diagnostics result now (even if it's `None` in most cases). I'm not sure if this can be improved.
An alternative strategy that can prevent the memory usage growth is to never produce diagnostics in hir-ty methods. Instead, lower all types in the hir crate when computing diagnostics from scratch (with diagnostics this time). But this has two serious disadvantages:
1. This can cause code duplication (although it can probably be not that bad, it will still mean a lot more code).
2. I believe we eventually want to compute diagnostics for the *entire* workspace (either on-type or on-save or something alike), so users can know when they have diagnostics even in inactive files. Choosing this approach will mean we lose all precomputed salsa queries. For one file this is fine, for the whole workspace this will be very slow.
2024-12-04 14:22:56 +02:00
