Hayashi Mikihiro
7c7d440188
add assert to check ast_index smaller than INNER_ATTR_SET_BIT
...
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
2025-05-08 23:37:47 +09:00
Chayim Refael Friedman
6e8ad1666a
Fix postfix snippets duplicating derefs
2025-05-08 11:44:38 +03:00
Lukas Wirth
8d9b318a85
perf: Request cancellation while processing changed files
2025-05-08 10:18:17 +02:00
Chayim Refael Friedman
70842faa4d
Still complete parentheses & method call arguments if there are existing parentheses, but they are after a newline
2025-05-08 11:05:39 +03:00
bors
4c2b4ca4f2
Auto merge of #140106 - dianne:deref-pat-usefulness, r=Nadrieril
...
allow deref patterns to participate in exhaustiveness analysis
Per [this proposal](https://hackmd.io/4qDDMcvyQ-GDB089IPcHGg#Exhaustiveness ), this PR allows deref patterns to participate in exhaustiveness analysis. Currently all deref patterns enforce `DerefPure` bounds on their scrutinees, so this assumes all patterns it's analyzing are well-behaved. This also doesn't support [mixed exhaustiveness](https://hackmd.io/4qDDMcvyQ-GDB089IPcHGg#Mixed-exhaustiveness ), and instead emits an error if deref patterns are used together with normal constructors. I think mixed exhaustiveness would be nice to have (especially if we eventually want to support arbitrary `Deref` impls[^1]), but it'd require more work to get reasonable diagnostics[^2].
Tracking issue for deref patterns: #87121
r? `@Nadrieril`
[^1]: Regardless of whether we support limited exhaustiveness checking for untrusted `Deref` or always require other arms to be exhaustive, I think it'd be useful to allow mixed matching for user-defined smart pointers. And it'd be strange if it worked there but not for `Cow`.
[^2]: I think listing out witnesses of non-exhaustiveness can be confusing when they're not necessarily disjoint, and when you only need to cover some of them, so we'd probably want special formatting and/or explanatory subdiagnostics. And if it's implemented similarly to unions, we'd probably also want some way of merging witnesses; the way witnesses for unions can appear duplicated is pretty unfortunate. I'm not sure yet how the diagnostics should look, especially for deeply nested patterns.
2025-05-08 02:16:45 +00:00
bors
24390f60d6
Auto merge of #137995 - hkBst:parse_format_reuse_unescape, r=nnethercote
...
Remove duplicate impl of string unescape from parse_format
r? `@nnethercote`
2025-05-07 06:18:39 +00:00
dianne
eb446f92fd
add stubbed-out cases for rust-analyzer
...
rust-analyzer doesn't construct `DerefPattern(_)` constructors, so these
shouldn't crash. It looks like this is how slice patterns are
implemented too.
2025-05-06 18:53:55 -07:00
Hayashi Mikihiro
0235ff883f
extract function: doc_attributes to find def from inner doc
...
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
2025-05-07 03:12:19 +09:00
Hayashi Mikihiro
cc0e3acd91
add doc link test for hover
...
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
2025-05-07 00:36:52 +09:00
Hayashi Mikihiro
318185720c
add doc link test for goto def
...
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
2025-05-07 00:36:42 +09:00
Hayashi Mikihiro
778322eb31
check module path inner or outer
...
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
2025-05-07 00:36:17 +09:00
Marijn Schouten
618c3de146
Remove duplicate impl of string unescape
2025-05-06 10:00:22 +00:00
Lukas Wirth
debaef80be
Merge pull request #19738 from ChayimFriedman2/weird-gats
...
fix: Don't panic on some weird code
2025-05-06 09:05:19 +00:00
Hayashi Mikihiro
ab4ba5cd29
Remove ast index mask
...
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
2025-05-06 17:45:09 +09:00
Hayashi Mikihiro
52b523aabe
import std::iter::repeat
...
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
2025-05-06 17:45:09 +09:00
Hayashi Mikihiro
7d6956ea57
Update crates/hir-expand/src/attrs.rs
...
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2025-05-06 17:45:09 +09:00
Hayashi Mikihiro
b786f98761
Update crates/hir-expand/src/attrs.rs
...
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2025-05-06 17:45:09 +09:00
Hayashi Mikihiro
9f6b4255c2
fix: resolve doc path if outer comments exist on module and replace from cfg_attr bit to doc_place bit
...
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
2025-05-06 17:45:09 +09:00
Chayim Refael Friedman
3b3e89240d
Don't panic on some weird code
2025-05-06 10:54:35 +03:00
Lukas Wirth
8c43442365
Merge pull request #19721 from ChayimFriedman2/more-parallel
...
Better handle parallelism in cache priming
2025-05-06 07:40:56 +00:00
Chayim Refael Friedman
f23af9291c
Notify the user that we're collecting symbols
...
It could be confusing if they see "Indexing n/n" but cache priming does not finish.
2025-05-06 10:29:53 +03:00
Stuart Cook
9f4e2cc51d
Rollup merge of #140035 - fee1-dead-contrib:push-oszwkkvmpkks, r=jieyouxu,wesleywiser
...
Implement RFC 3503: frontmatters
Tracking issue: #136889
Supercedes #137193 . This implements [RFC 3503](https://github.com/rust-lang/rfcs/blob/master/text/3503-frontmatter.md ).
This might break rust-analyzer. Will look into how to fix that.
Suggestions welcome for how to improve diagnostics.
2025-05-06 16:28:39 +10:00
Chayim Refael Friedman
1c7a94f37d
Add a --num-threads to the prime-caches CLI command
...
And make it parallel by default (and remove the `--parallel` flag) to mirror the IDE cache priming.
2025-05-05 23:55:11 +03:00
Chayim Refael Friedman
27dc8ad21b
Better manage parallel prime caches
...
To make best use of available cores, and don't waste time waiting for other tasks. See the comments in the code for explanation.
2025-05-05 23:54:34 +03:00
Victor
32e09de7c2
Support environment variable CARGO_MANIFEST_PATH.
2025-05-05 22:13:48 +02:00
Deadbeef
9fce1dfac5
Implement RFC 3503: frontmatters
...
Supercedes #137193
2025-05-05 23:10:08 +08:00
Lukas Wirth
d7e977a8f1
Merge pull request #19750 from Veykril/push-zvvsopwxovrn
...
fix: Remove unnecessary token length check for macros in renaming
2025-05-05 15:06:16 +00:00
Lukas Wirth
46df704c89
fix: Remove unnecessary token length check for macros in renaming
2025-05-05 16:54:38 +02:00
Lukas Wirth
d40455fec0
Merge pull request #19749 from Veykril/push-tsxvxzzmlxpq
...
refactor: Remove unnecessary `AsAny` trait
2025-05-05 14:53:57 +00:00
Lukas Wirth
091b7b2465
refactor: Remove unnecessary AsAny trait
2025-05-05 16:42:17 +02:00
Vishruth-Thimmaiah
109d933736
fix: negative nums in concat! expansion
2025-05-05 19:00:24 +05:30
Lukas Wirth
fdfa707807
Merge pull request #19747 from Veykril/push-kqxvxrxozswr
...
fix: Fix `move_bounds` assists not working for lifetimes
2025-05-05 13:18:20 +00:00
Lukas Wirth
f9c83edf12
fix: Fix move_bounds assists not working for lifetimes
2025-05-05 15:07:36 +02:00
Lukas Wirth
aaefc26412
Merge pull request #19746 from Veykril/push-swvuyqwwplrt
...
fix: Fix proc-macro API creating malformed negative literals
2025-05-05 12:21:23 +00:00
Lukas Wirth
361a927a71
fix: Fix proc-macro API creating malformed negative literals
2025-05-05 14:10:42 +02:00
Lukas Wirth
cb18ead726
minor: Add more proc-macro tests for parsing negative literals
2025-05-05 13:44:45 +02:00
Lukas Wirth
75af9ddb3f
Merge pull request #19745 from Veykril/push-rnqulnqvltro
...
minor: Add a mbe test for parsing negative literals
2025-05-05 10:21:54 +00:00
Lukas Wirth
9d1364b730
minor: Add a mbe test for parsing negative literals
2025-05-05 12:10:48 +02:00
Lukas Wirth
f898e3f524
Merge pull request #19740 from vishruth-thimmaiah/unwrap_path_type
...
feat: add an assist to unwrap a type with a generic arg
2025-05-05 09:37:14 +00:00
Vishruth-Thimmaiah
4771b84a75
feat: add an assist to unwrap a type with a generic arg
...
This assist unwraps a type into its generic type argument, ignoring
const and lifetime arguments
2025-05-05 13:22:02 +05:30
Lukas Wirth
581646236e
refactor: De-arc defmap queries
2025-05-05 09:04:52 +02:00
Lukas Wirth
b1bd478029
Merge pull request #19742 from Veykril/push-ykmuwtkzruqm
...
fix: Fix incorrect handling of unresolved non-module imports in name resolution
2025-05-05 06:41:34 +00:00
Lukas Wirth
9a62507f2e
Fix incorrect handling of unresolved non-module imports in name resolution
2025-05-05 08:29:34 +02:00
Lukas Wirth
3b57c00151
Merge pull request #19739 from Veykril/push-kpozprqnsmkk
...
Disable fixpoint for variance computation temporarily
2025-05-04 04:26:25 +00:00
Lukas Wirth
7d51ec376a
Disable fixpoint for variance computation temporarily
2025-05-04 06:09:34 +02:00
A4-Tacks
850d122fd4
Improve let snippet
2025-05-03 17:04:11 +08:00
A4-Tacks
d922c20158
Improve the let code snippet
2025-05-03 13:15:32 +08:00
Lukas Wirth
6f9c62dfec
Merge pull request #19733 from ShoyuVanilla/issue-19724
...
fix: Implement mut to const ptr cast for method resolution
2025-05-02 20:48:24 +00:00
Lukas Wirth
3bf5d7f7f9
Merge pull request #19732 from ShoyuVanilla/issue-19730
...
fix: Correct assoc ty bound var starting index
2025-05-02 20:46:54 +00:00
Shoyu Vanilla
4aa98bf1d7
fix: Implement mut to const ptr cast for method resolution
2025-05-03 03:01:40 +09:00
