22965 commits

Author	SHA1	Message	Date
A4-Tacks	db027e057d	Fix indent for unresolved_field fixes ... Examples --- ```rust mod indent { struct Foo {} fn foo() { let foo = Foo{}; foo.bar$0; } } ``` **Before this PR**: ```rust mod indent { struct Foo { bar: () } fn foo() { let foo = Foo{}; foo.bar; } } ``` **After this PR**: ```rust mod indent { struct Foo { bar: () } fn foo() { let foo = Foo{}; foo.bar; } } ``` --- New field list add newline ```rust mod indent { struct Foo; fn foo() { Foo.bar$0; } } ``` **Before this PR**: ```rust mod indent { struct Foo{ bar: () } fn foo() { Foo.bar; } } ``` **After this PR**: ```rust mod indent { struct Foo { bar: (), } fn foo() { Foo.bar; } } ```	2025-09-05 15:57:51 +08:00
Chayim Refael Friedman	6bcfbbe8f9	Remove SolverDefId::ForeignId ... Replace it with normal `SolverDefId::TypeAliasId`. The split caused a very funny bug where code was getting `TypeAliasId` where it expected `ForeignId`, because `TypeAliasId` had a `From` impl from `hir_def::TypeAliasId` and `ForeignId` had not, plus a careless `into()`. I could've fixed this specific bug but opted to remove the split instead; currently, it just provides more room for bugs, as we don't have typed IDs for the solver anyway, and even when we'll have (hopefully), that doesn't seem like a very useful distinction, for example in hir-def foreign types are just `TypeAliasId` with some flags. Constructing a test for this isn't trivial; the trivial test (creating a foreign type, even proving a trait bound for it) fails to fail before the change, probably because we don't use the new solver everywhere yet so we don't trigger this specific code path.	2025-08-26 19:33:46 +03:00
Shoyu Vanilla (Flint)	12604577dd	Merge pull request #20399 from rust-lang/veykril/push-klrwvmzokqwu ... Enable warning logs by default	2025-08-26 05:56:22 +00:00
Shoyu Vanilla (Flint)	0358021a8f	Merge pull request #20534 from A4-Tacks/tog-macro-delim-semicolon ... Fix ExprStmt delete semicolon for toggle_macro_delimiter	2025-08-26 05:55:08 +00:00
Shoyu Vanilla (Flint)	d86cf448c3	Merge pull request #20509 from A4-Tacks/fix-move-guard-to-arm-indent ... Fix indent for move_guard_to_arm_body	2025-08-26 05:52:06 +00:00
Shoyu Vanilla (Flint)	25adf3464c	Merge pull request #20520 from ChayimFriedman2/reborrow ... feat: Add an option to remove reborrows from adjustment inlay hints	2025-08-26 05:48:34 +00:00
Shoyu Vanilla (Flint)	51f7f7903d	Merge pull request #20537 from ChayimFriedman2/new-solver-normalize ... fix: Normalize all types when finishing inference	2025-08-26 05:31:07 +00:00
Chayim Refael Friedman	870cb3329b	Merge pull request #20423 from ShoyuVanilla/import-2024 ... Make import sorting order follow 2024 edition style	2025-08-25 19:19:31 +00:00
Chayim Refael Friedman	fd77af3a78	Don't map Chalk's Normalize to next solver's NormalizesTo ... `NormalizesTo` is a private predicate that should not be used outside the solver. For normalization, rustc uses `AliasRelate`, so replace with that.	2025-08-25 20:56:45 +03:00
Chayim Refael Friedman	1ff80eefe1	Normalize all types when finishing inference ... The new solver does not eagerly normalize, but things after inference expect types to be normalized. rustc does the same. Also, I'm afraid other things in r-a don't expect results of the solver to be unnormalized. We'll need to handle that.	2025-08-25 20:23:18 +03:00
A4-Tacks	55b1ddbcc3	Fix ExprStmt delete semicolon for toggle_macro_delimiter	2025-08-25 16:45:12 +08:00
Shoyu Vanilla	1c8fd6af24	fix: Masquerade as nightly cargo when invoking flycheck with -Zscript	2025-08-24 23:17:23 +09:00
Shoyu Vanilla (Flint)	db7b3b1b91	Merge pull request #20523 from ChayimFriedman2/opaque-generics ... fix: Fix opaque generics	2025-08-24 06:59:38 +00:00
Chayim Refael Friedman	03173a7ec7	Fix opaque generics ... The parent generics were incorrectly not considered for TAIT. I'm not convinced we should follow rustc here, also there are items (opaques) with more than 1 parent (opaque -> fn/type alias -> impl/trait) and I'm not sure we properly account for that in all places, but for now I left it as-is. Also fix a bug where lifetimes' indices were incorrect when there is a self param (they started from 0 instead of 1).	2025-08-24 08:49:40 +03:00
Chayim Refael Friedman	05b7cbc236	Merge pull request #20507 from A4-Tacks/suggest-return-expr ... Add ReturnExpr completion suggest	2025-08-24 00:46:49 +00:00
A4-Tacks	ac7615b2a3	Add ReturnExpr completion suggest	2025-08-24 08:26:25 +08:00
Chayim Refael Friedman	35369557a6	Merge pull request #20512 from A4-Tacks/arith-op-not-on-selected ... replace_arith_op not applicable on selected	2025-08-24 00:17:09 +00:00
A4-Tacks	0fe2d7ffa1	replace_arith_op not applicable on selected	2025-08-24 07:57:50 +08:00
Chayim Refael Friedman	eaf71411a9	Add an option to remove reborrows from adjustment inlay hints ... Reborrows are consecutive deref then ref. Make it the default because reborrows are mostly useless to the programmer. Also rename `rust-analyzer.inlayHints.expressionAdjustmentHints.enable: "reborrow"` to `rust-analyzer.inlayHints.expressionAdjustmentHints.enable: "borrows"`, as it's not about reborrows but about any ref/deref and it's confusing with the new setting.	2025-08-24 02:26:37 +03:00
Chayim Refael Friedman	544ef84898	Merge pull request #20513 from A4-Tacks/let-in-let-chain ... Add let in let-chain completion support	2025-08-23 22:17:27 +00:00
Chayim Refael Friedman	71662e4c65	Merge pull request #20518 from A4-Tacks/fix-else-in-in-let ... Fix `else` completion in `let _ = if x {} $0`	2025-08-23 22:07:13 +00:00
Chayim Refael Friedman	413ed5a361	Merge pull request #20511 from A4-Tacks/fix-conv-int-lit-on-selected ... convert_integer_literal not on selected	2025-08-23 22:03:17 +00:00
A4-Tacks	3e48de3905	Fix else completion in let _ = if x {} $0	2025-08-23 17:48:30 +08:00
A4-Tacks	6a7a0fac95	Add let in let-chain completion support ... Example --- ```rust fn f() { if true && $0 {} } ``` -> ```rust fn f() { if true && let $1 = $0 {} } ```	2025-08-22 21:58:49 +08:00
A4-Tacks	5f8cfeb3f4	fix: convert_integer_literal not on selected ... `convert_integer_literal` can only convert the first literal, it is not reasonable to apply it when selected Example --- ```rust fn main() { $01+1$0; } ``` **Assist old outputs**: ``` Convert 1 to 0b1 Convert 1 to 0o1 Convert 1 to 0x1 Replace arithmetic with call to checked_* Replace arithmetic with call to saturating_* Replace arithmetic with call to wrapping_* Extract into variable Extract into constant Extract into static Extract into function ``` **Assist this PR outputs**: ``` Replace arithmetic with call to checked_* Replace arithmetic with call to saturating_* Replace arithmetic with call to wrapping_* Extract into variable Extract into constant Extract into static Extract into function ```	2025-08-22 17:13:30 +08:00
Lukas Wirth	0914f78f23	Fix panic in syntax_highlighting	2025-08-22 09:00:25 +02:00
A4-Tacks	f5f797e2d3	Fix indent for move_guard_to_arm_body ... Input: ```rust fn main() { match 92 { x $0if true && true && true => { { false } }, _ => true } } ``` Old output: ```rust fn main() { match 92 { x => if true && true && true { { { false } } }, _ => true }; } ``` This PR fixed: ```rust fn main() { match 92 { x => if true && true && true { { { false } } }, _ => true } } ```	2025-08-22 11:43:03 +08:00
Chayim Refael Friedman	14872a5332	Merge pull request #20504 from ShoyuVanilla/ethereum-madness ... fix: Infinite recursion while lowering assoc type bounds from supertraits	2025-08-21 20:45:29 +00:00
Shoyu Vanilla	80ce520660	fix: Infinite recursion while lowering assoc type bounds from supertraits	2025-08-22 05:24:33 +09:00
Chayim Refael Friedman	df375b0855	Remove unnecessary salsa::attach() calls	2025-08-21 22:40:58 +03:00
Chayim Refael Friedman	7a27a27f4b	Attach the DB when mapping the result of world_symbols() ... We call `try_to_nav()` there.	2025-08-21 08:06:43 +03:00
Chayim Refael Friedman	243d158e88	Attach the DB in symbol queries	2025-08-21 07:14:55 +03:00
lcnr	1d4f709e60	user facing code should use not use PostAnalysis	2025-08-19 08:24:34 +02:00
Lukas Wirth	aed0fec1a9	Auto-attach database in Analysis calls	2025-08-18 09:52:23 +02:00
Shoyu Vanilla (Flint)	becf04b67a	Merge pull request #20442 from ChayimFriedman2/unqualify ... fix: Only import the item in "Unqualify method call" if needed	2025-08-18 06:24:35 +00:00
jackh726	596a6bf6be	Remove fixme comment	2025-08-17 16:04:50 +00:00
jackh726	3ceaf806f6	Add FIXME in named_associated_type_shorthand_candidates	2025-08-17 16:04:50 +00:00
jackh726	33cc8609dc	Add fixme to associated_ty_item_bounds	2025-08-17 16:04:50 +00:00
jackh726	ec26d9f48a	Update fixme	2025-08-17 16:04:50 +00:00
jackh726	cdf51f28f4	Add new_empty_tuple	2025-08-17 16:04:50 +00:00
jackh726	84388ceb0e	Remove a bunch of stuff from chalk_db	2025-08-17 16:04:50 +00:00
jackh726	766e6b58ad	Use impl_trait_ns in Impl::trait_ref	2025-08-17 16:04:50 +00:00
jackh726	e979349978	Switch TraitRef in hir::TraitRef to next solver	2025-08-17 16:04:50 +00:00
jackh726	7f0ec8b69f	Replace layout_of_ty with layout_of_ty_ns	2025-08-17 16:04:50 +00:00
jackh726	da6fbda16c	Remove all_super_traits in dyn_compatibility	2025-08-17 16:04:50 +00:00
jackh726	a66ba475bf	Switch generics_require_sized_self to next solver	2025-08-17 16:04:50 +00:00
jackh726	74a9d17920	Convert more of dyn_compatibility to next-solver	2025-08-17 16:04:50 +00:00
jackh726	f9d2d2dd87	Switch associated_type_shorthand_candidates to lower_nextsolver	2025-08-17 16:04:50 +00:00
jackh726	496f5f9e96	Cleanup assoc_type_shorthand_candidates	2025-08-17 16:04:50 +00:00
jackh726	aa890b49ff	Change direct_super_traits to use generic_predicates_for_param_ns	2025-08-17 16:04:50 +00:00