mirror of
https://github.com/rust-lang/rust-analyzer.git
synced 2025-10-01 06:11:35 +00:00

This PR touches a lot of parts. But the main changes are changing `hir_expand::Name` to be raw edition-dependently and only when necessary (unrelated to how the user originally wrote the identifier), and changing `is_keyword()` and `is_raw_identifier()` to be edition-aware (this was done in #17896, but the FIXMEs were fixed here). It is possible that I missed some cases, but most IDE parts should properly escape (or not escape) identifiers now. The rules of thumb are: - If we show the identifier to the user, its rawness should be determined by the edition of the edited crate. This is nice for IDE features, but really important for changes we insert to the source code. - For tests, I chose `Edition::CURRENT` (so we only have to (maybe) update tests when an edition becomes stable, to avoid churn). - For debugging tools (helper methods and logs), I used `Edition::LATEST`.
277 lines
10 KiB
Rust
277 lines
10 KiB
Rust
//! `completions` crate provides utilities for generating completions of user input.
|
|
|
|
mod completions;
|
|
mod config;
|
|
mod context;
|
|
mod item;
|
|
mod render;
|
|
|
|
mod snippet;
|
|
#[cfg(test)]
|
|
mod tests;
|
|
|
|
use ide_db::{
|
|
helpers::mod_path_to_ast,
|
|
imports::{
|
|
import_assets::NameToImport,
|
|
insert_use::{self, ImportScope},
|
|
},
|
|
items_locator, FilePosition, RootDatabase,
|
|
};
|
|
use syntax::algo;
|
|
use text_edit::TextEdit;
|
|
|
|
use crate::{
|
|
completions::Completions,
|
|
context::{
|
|
CompletionAnalysis, CompletionContext, NameRefContext, NameRefKind, PathCompletionCtx,
|
|
PathKind,
|
|
},
|
|
};
|
|
|
|
pub use crate::{
|
|
config::{CallableSnippets, CompletionConfig},
|
|
item::{
|
|
CompletionItem, CompletionItemKind, CompletionRelevance, CompletionRelevancePostfixMatch,
|
|
},
|
|
snippet::{Snippet, SnippetScope},
|
|
};
|
|
|
|
//FIXME: split the following feature into fine-grained features.
|
|
|
|
// Feature: Magic Completions
|
|
//
|
|
// In addition to usual reference completion, rust-analyzer provides some ✨magic✨
|
|
// completions as well:
|
|
//
|
|
// Keywords like `if`, `else` `while`, `loop` are completed with braces, and cursor
|
|
// is placed at the appropriate position. Even though `if` is easy to type, you
|
|
// still want to complete it, to get ` { }` for free! `return` is inserted with a
|
|
// space or `;` depending on the return type of the function.
|
|
//
|
|
// When completing a function call, `()` are automatically inserted. If a function
|
|
// takes arguments, the cursor is positioned inside the parenthesis.
|
|
//
|
|
// There are postfix completions, which can be triggered by typing something like
|
|
// `foo().if`. The word after `.` determines postfix completion. Possible variants are:
|
|
//
|
|
// - `expr.if` -> `if expr {}` or `if let ... {}` for `Option` or `Result`
|
|
// - `expr.match` -> `match expr {}`
|
|
// - `expr.while` -> `while expr {}` or `while let ... {}` for `Option` or `Result`
|
|
// - `expr.ref` -> `&expr`
|
|
// - `expr.refm` -> `&mut expr`
|
|
// - `expr.let` -> `let $0 = expr;`
|
|
// - `expr.lete` -> `let $1 = expr else { $0 };`
|
|
// - `expr.letm` -> `let mut $0 = expr;`
|
|
// - `expr.not` -> `!expr`
|
|
// - `expr.dbg` -> `dbg!(expr)`
|
|
// - `expr.dbgr` -> `dbg!(&expr)`
|
|
// - `expr.call` -> `(expr)`
|
|
//
|
|
// There also snippet completions:
|
|
//
|
|
// .Expressions
|
|
// - `pd` -> `eprintln!(" = {:?}", );`
|
|
// - `ppd` -> `eprintln!(" = {:#?}", );`
|
|
//
|
|
// .Items
|
|
// - `tfn` -> `#[test] fn feature(){}`
|
|
// - `tmod` ->
|
|
// ```rust
|
|
// #[cfg(test)]
|
|
// mod tests {
|
|
// use super::*;
|
|
//
|
|
// #[test]
|
|
// fn test_name() {}
|
|
// }
|
|
// ```
|
|
//
|
|
// And the auto import completions, enabled with the `rust-analyzer.completion.autoimport.enable` setting and the corresponding LSP client capabilities.
|
|
// Those are the additional completion options with automatic `use` import and options from all project importable items,
|
|
// fuzzy matched against the completion input.
|
|
//
|
|
// image::https://user-images.githubusercontent.com/48062697/113020667-b72ab880-917a-11eb-8778-716cf26a0eb3.gif[]
|
|
|
|
/// Main entry point for completion. We run completion as a two-phase process.
|
|
///
|
|
/// First, we look at the position and collect a so-called `CompletionContext`.
|
|
/// This is a somewhat messy process, because, during completion, syntax tree is
|
|
/// incomplete and can look really weird.
|
|
///
|
|
/// Once the context is collected, we run a series of completion routines which
|
|
/// look at the context and produce completion items. One subtlety about this
|
|
/// phase is that completion engine should not filter by the substring which is
|
|
/// already present, it should give all possible variants for the identifier at
|
|
/// the caret. In other words, for
|
|
///
|
|
/// ```no_run
|
|
/// fn f() {
|
|
/// let foo = 92;
|
|
/// let _ = bar$0
|
|
/// }
|
|
/// ```
|
|
///
|
|
/// `foo` *should* be present among the completion variants. Filtering by
|
|
/// identifier prefix/fuzzy match should be done higher in the stack, together
|
|
/// with ordering of completions (currently this is done by the client).
|
|
///
|
|
/// # Speculative Completion Problem
|
|
///
|
|
/// There's a curious unsolved problem in the current implementation. Often, you
|
|
/// want to compute completions on a *slightly different* text document.
|
|
///
|
|
/// In the simplest case, when the code looks like `let x = `, you want to
|
|
/// insert a fake identifier to get a better syntax tree: `let x = complete_me`.
|
|
///
|
|
/// We do this in `CompletionContext`, and it works OK-enough for *syntax*
|
|
/// analysis. However, we might want to, eg, ask for the type of `complete_me`
|
|
/// variable, and that's where our current infrastructure breaks down. salsa
|
|
/// doesn't allow such "phantom" inputs.
|
|
///
|
|
/// Another case where this would be instrumental is macro expansion. We want to
|
|
/// insert a fake ident and re-expand code. There's `expand_speculative` as a
|
|
/// workaround for this.
|
|
///
|
|
/// A different use-case is completion of injection (examples and links in doc
|
|
/// comments). When computing completion for a path in a doc-comment, you want
|
|
/// to inject a fake path expression into the item being documented and complete
|
|
/// that.
|
|
///
|
|
/// IntelliJ has CodeFragment/Context infrastructure for that. You can create a
|
|
/// temporary PSI node, and say that the context ("parent") of this node is some
|
|
/// existing node. Asking for, eg, type of this `CodeFragment` node works
|
|
/// correctly, as the underlying infrastructure makes use of contexts to do
|
|
/// analysis.
|
|
pub fn completions(
|
|
db: &RootDatabase,
|
|
config: &CompletionConfig,
|
|
position: FilePosition,
|
|
trigger_character: Option<char>,
|
|
) -> Option<Vec<CompletionItem>> {
|
|
let (ctx, analysis) = &CompletionContext::new(db, position, config)?;
|
|
let mut completions = Completions::default();
|
|
|
|
// prevent `(` from triggering unwanted completion noise
|
|
if trigger_character == Some('(') {
|
|
if let CompletionAnalysis::NameRef(NameRefContext {
|
|
kind:
|
|
NameRefKind::Path(
|
|
path_ctx @ PathCompletionCtx { kind: PathKind::Vis { has_in_token }, .. },
|
|
),
|
|
..
|
|
}) = analysis
|
|
{
|
|
completions::vis::complete_vis_path(&mut completions, ctx, path_ctx, has_in_token);
|
|
}
|
|
return Some(completions.into());
|
|
}
|
|
|
|
// when the user types a bare `_` (that is it does not belong to an identifier)
|
|
// the user might just wanted to type a `_` for type inference or pattern discarding
|
|
// so try to suppress completions in those cases
|
|
if trigger_character == Some('_') && ctx.original_token.kind() == syntax::SyntaxKind::UNDERSCORE
|
|
{
|
|
if let CompletionAnalysis::NameRef(NameRefContext {
|
|
kind:
|
|
NameRefKind::Path(
|
|
path_ctx @ PathCompletionCtx {
|
|
kind: PathKind::Type { .. } | PathKind::Pat { .. },
|
|
..
|
|
},
|
|
),
|
|
..
|
|
}) = analysis
|
|
{
|
|
if path_ctx.is_trivial_path() {
|
|
return None;
|
|
}
|
|
}
|
|
}
|
|
|
|
{
|
|
let acc = &mut completions;
|
|
|
|
match analysis {
|
|
CompletionAnalysis::Name(name_ctx) => completions::complete_name(acc, ctx, name_ctx),
|
|
CompletionAnalysis::NameRef(name_ref_ctx) => {
|
|
completions::complete_name_ref(acc, ctx, name_ref_ctx)
|
|
}
|
|
CompletionAnalysis::Lifetime(lifetime_ctx) => {
|
|
completions::lifetime::complete_label(acc, ctx, lifetime_ctx);
|
|
completions::lifetime::complete_lifetime(acc, ctx, lifetime_ctx);
|
|
}
|
|
CompletionAnalysis::String { original, expanded: Some(expanded) } => {
|
|
completions::extern_abi::complete_extern_abi(acc, ctx, expanded);
|
|
completions::format_string::format_string(acc, ctx, original, expanded);
|
|
completions::env_vars::complete_cargo_env_vars(acc, ctx, original, expanded);
|
|
}
|
|
CompletionAnalysis::UnexpandedAttrTT {
|
|
colon_prefix,
|
|
fake_attribute_under_caret: Some(attr),
|
|
extern_crate,
|
|
} => {
|
|
completions::attribute::complete_known_attribute_input(
|
|
acc,
|
|
ctx,
|
|
colon_prefix,
|
|
attr,
|
|
extern_crate.as_ref(),
|
|
);
|
|
}
|
|
CompletionAnalysis::UnexpandedAttrTT { .. } | CompletionAnalysis::String { .. } => (),
|
|
}
|
|
}
|
|
|
|
Some(completions.into())
|
|
}
|
|
|
|
/// Resolves additional completion data at the position given.
|
|
/// This is used for import insertion done via completions like flyimport and custom user snippets.
|
|
pub fn resolve_completion_edits(
|
|
db: &RootDatabase,
|
|
config: &CompletionConfig,
|
|
FilePosition { file_id, offset }: FilePosition,
|
|
imports: impl IntoIterator<Item = (String, String)>,
|
|
) -> Option<Vec<TextEdit>> {
|
|
let _p = tracing::info_span!("resolve_completion_edits").entered();
|
|
let sema = hir::Semantics::new(db);
|
|
|
|
let original_file = sema.parse(sema.attach_first_edition(file_id)?);
|
|
let original_token =
|
|
syntax::AstNode::syntax(&original_file).token_at_offset(offset).left_biased()?;
|
|
let position_for_import = &original_token.parent()?;
|
|
let scope = ImportScope::find_insert_use_container(position_for_import, &sema)?;
|
|
|
|
let current_module = sema.scope(position_for_import)?.module();
|
|
let current_crate = current_module.krate();
|
|
let current_edition = current_crate.edition(db);
|
|
let new_ast = scope.clone_for_update();
|
|
let mut import_insert = TextEdit::builder();
|
|
|
|
let cfg = config.import_path_config();
|
|
|
|
imports.into_iter().for_each(|(full_import_path, imported_name)| {
|
|
let items_with_name = items_locator::items_with_name(
|
|
&sema,
|
|
current_crate,
|
|
NameToImport::exact_case_sensitive(imported_name),
|
|
items_locator::AssocSearchMode::Include,
|
|
);
|
|
let import = items_with_name
|
|
.filter_map(|candidate| {
|
|
current_module.find_use_path(db, candidate, config.insert_use.prefix_kind, cfg)
|
|
})
|
|
.find(|mod_path| mod_path.display(db, current_edition).to_string() == full_import_path);
|
|
if let Some(import_path) = import {
|
|
insert_use::insert_use(
|
|
&new_ast,
|
|
mod_path_to_ast(&import_path, current_edition),
|
|
&config.insert_use,
|
|
);
|
|
}
|
|
});
|
|
|
|
algo::diff(scope.as_syntax_node(), new_ast.as_syntax_node()).into_text_edit(&mut import_insert);
|
|
Some(vec![import_insert.finish()])
|
|
}
|