mirror of
https://github.com/rust-lang/rust-analyzer.git
synced 2025-09-26 11:59:49 +00:00
9c49f6c36e
1216: Basic Chalk integration r=matklad a=flodiebold This replaces the ad-hoc `implements` check by Chalk. It doesn't yet any new functionality (e.g. where clauses aren't passed to Chalk yet). The tests that exist actually work, but it needs some refactoring, currently crashes when running analysis on the RA repo, and depends on rust-lang/chalk#216 which isn't merged yet 😄 The main work here is converting stuff back and forth and providing Chalk with the information it needs, and the canonicalization logic. Since canonicalization depends a lot on the inference table, I don't think we can currently reuse the logic from Chalk, so we need to implement it ourselves; it's not actually that complicated anyway ;) I realized that we need a `Ty::Bound` variant separate from `Ty::Param` -- these are two different things, and I think type parameters inside a function actually need to be represented in Chalk as `Placeholder` types. ~~Currently this crashes in the 'real' world because we don't yet do canonicalization when filtering method candidates. Proper canonicalization needs the inference table (to collapse different inference variables that have already been unified), but we need to be able to call the method candidate selection from the completion code... So I'm currently thinking how to best handle that 😄~~ Co-authored-by: Florian Diebold <flodiebold@gmail.com> |
||
|---|---|---|
| .. | ||
| gen_lsp_server | ||
| ra_arena | ||
| ra_assists | ||
| ra_batch | ||
| ra_cli | ||
| ra_db | ||
| ra_fmt | ||
| ra_hir | ||
| ra_ide_api | ||
| ra_lsp_server | ||
| ra_mbe | ||
| ra_parser | ||
| ra_prof | ||
| ra_project_model | ||
| ra_syntax | ||
| ra_text_edit | ||
| ra_tt | ||
| test_utils | ||
| thread_worker | ||
| tools | ||