mirror of
https://github.com/rust-lang/rust-analyzer.git
synced 2025-09-29 05:15:04 +00:00
fd243cd0fb
Use more correct handling of lint attributes
The previous analysis was top-down, and worked on a single file (expanding macros). The new analysis is bottom-up, starting from the diagnostics and climbing up the syntax and module tree.
While this is more efficient (and in fact, efficiency was the motivating reason to work on this), unfortunately the code was already fast enough. But luckily, it also fixes a correctness problem: outline parent modules' attributes were not respected for the previous analysis. Case lints specifically did their own analysis to accommodate that, but it was limited to only them. The new analysis works on all kinds of lints, present and future.
It was basically impossible to fix the old analysis without rewriting it because navigating the module hierarchy must come bottom-up, and if we already have a bottom-up analysis (including syntax analysis because modules can be nested in other syntax elements, including macros), it makes sense to use only this kind of analysis.
Few other bugs (not fundamental to the previous analysis) are also fixed, e.g. overwriting of lint levels (i.e. `#[allow(lint)] mod foo { #[warn(lint)] mod bar; }`.
After this PR is merged I intend to work on an editor command that does workspace-wide diagnostics analysis (that is, `rust-analyzer diagnostics` but from your editor and without having to spawn a new process, which will have to analyze the workspace from scratch). This can be useful to users who do not want to enable check on save because of its overhead, but want to see workspace wide diagnostics from r-a (or to maintainers of rust-analyzer).
Closes #18086.
Closes #18081.
Fixes #18056.
|
||
|---|---|---|
| .. | ||
| body | ||
| data | ||
| dyn_map | ||
| hir | ||
| item_tree | ||
| macro_expansion_tests | ||
| nameres | ||
| path | ||
| attr.rs | ||
| body.rs | ||
| builtin_type.rs | ||
| child_by_source.rs | ||
| data.rs | ||
| db.rs | ||
| dyn_map.rs | ||
| expander.rs | ||
| find_path.rs | ||
| generics.rs | ||
| hir.rs | ||
| import_map.rs | ||
| item_scope.rs | ||
| item_tree.rs | ||
| lang_item.rs | ||
| lib.rs | ||
| lower.rs | ||
| nameres.rs | ||
| path.rs | ||
| per_ns.rs | ||
| pretty.rs | ||
| resolver.rs | ||
| src.rs | ||
| test_db.rs | ||
| visibility.rs | ||