mirror of
https://github.com/rust-lang/rust-analyzer.git
synced 2025-10-16 21:38:39 +00:00
487 lines
12 KiB
Rust
487 lines
12 KiB
Rust
use ide_db::{famous_defs::FamousDefs, traits::resolve_target_trait};
|
|
use syntax::{
|
|
AstNode, T,
|
|
ast::{
|
|
self, HasAttrs, HasGenericParams, HasName,
|
|
edit::{AstNodeEdit, IndentLevel},
|
|
make,
|
|
},
|
|
syntax_editor::{Element, Position, SyntaxEditor},
|
|
};
|
|
|
|
use crate::{AssistContext, AssistId, Assists};
|
|
|
|
// FIXME: Generate proper `index_mut` method body refer to `index` method body may impossible due to the unpredictable case [#15581].
|
|
// Here just leave the `index_mut` method body be same as `index` method body, user can modify it manually to meet their need.
|
|
|
|
// Assist: generate_mut_trait_impl
|
|
//
|
|
// Adds a IndexMut impl from the `Index` trait.
|
|
//
|
|
// ```
|
|
// # //- minicore: index
|
|
// pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
//
|
|
// impl<T> core::ops::Index$0<Axis> for [T; 3] {
|
|
// type Output = T;
|
|
//
|
|
// fn index(&self, index: Axis) -> &Self::Output {
|
|
// &self[index as usize]
|
|
// }
|
|
// }
|
|
// ```
|
|
// ->
|
|
// ```
|
|
// pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
//
|
|
// $0impl<T> core::ops::IndexMut<Axis> for [T; 3] {
|
|
// fn index_mut(&mut self, index: Axis) -> &mut Self::Output {
|
|
// &mut self[index as usize]
|
|
// }
|
|
// }
|
|
//
|
|
// impl<T> core::ops::Index<Axis> for [T; 3] {
|
|
// type Output = T;
|
|
//
|
|
// fn index(&self, index: Axis) -> &Self::Output {
|
|
// &self[index as usize]
|
|
// }
|
|
// }
|
|
// ```
|
|
pub(crate) fn generate_mut_trait_impl(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> {
|
|
let impl_def = ctx.find_node_at_offset::<ast::Impl>()?;
|
|
let indent = impl_def.indent_level();
|
|
|
|
let ast::Type::PathType(path) = impl_def.trait_()?.clone_subtree() else {
|
|
return None;
|
|
};
|
|
let trait_name = path.path()?.segment()?.name_ref()?;
|
|
|
|
let scope = ctx.sema.scope(impl_def.trait_()?.syntax())?;
|
|
let famous = FamousDefs(&ctx.sema, scope.krate());
|
|
|
|
let trait_ = resolve_target_trait(&ctx.sema, &impl_def)?;
|
|
let trait_new = get_trait_mut(&trait_, famous)?;
|
|
|
|
let new_trait_type = {
|
|
let mut trait_type_editor = SyntaxEditor::new(path.syntax().clone());
|
|
trait_type_editor
|
|
.replace(trait_name.syntax(), make::name_ref(trait_new).syntax().clone_for_update());
|
|
ast::PathType::cast(trait_type_editor.finish().new_root().clone())?
|
|
};
|
|
|
|
let new_trait_method_name = impl_def
|
|
.syntax()
|
|
.descendants()
|
|
.filter_map(ast::Name::cast)
|
|
.find_map(process_method_name)?;
|
|
|
|
let fn_ = impl_def.assoc_item_list()?.assoc_items().find_map(|it| match it {
|
|
ast::AssocItem::Fn(f) => Some(f),
|
|
_ => None,
|
|
})?;
|
|
let fn_ = ast::AssocItem::Fn(generate_fn(&fn_, new_trait_method_name)?).indent(IndentLevel(1));
|
|
|
|
let assoc_list = make::assoc_item_list(Some(vec![fn_]));
|
|
let new_impl = make::impl_trait(
|
|
impl_def.attrs(),
|
|
impl_def.unsafe_token().is_some(),
|
|
impl_def.generic_param_list(),
|
|
None,
|
|
None,
|
|
None,
|
|
false,
|
|
ast::Type::PathType(new_trait_type),
|
|
impl_def.self_ty()?,
|
|
impl_def.where_clause(),
|
|
None,
|
|
Some(assoc_list),
|
|
)
|
|
.indent(indent);
|
|
|
|
let target = impl_def.syntax().text_range();
|
|
acc.add(
|
|
AssistId::generate("generate_mut_trait_impl"),
|
|
format!("Generate `{trait_new}` impl from this `{trait_name}` trait"),
|
|
target,
|
|
|edit| {
|
|
let mut editor = edit.make_editor(impl_def.syntax());
|
|
editor.insert_all(
|
|
Position::before(impl_def.syntax()),
|
|
vec![
|
|
new_impl.syntax().syntax_element(),
|
|
make::tokens::whitespace(&format!("\n\n{indent}")).syntax_element(),
|
|
],
|
|
);
|
|
if let Some(cap) = ctx.config.snippet_cap {
|
|
let tabstop_before = edit.make_tabstop_before(cap);
|
|
editor.add_annotation(new_impl.syntax(), tabstop_before);
|
|
}
|
|
edit.add_file_edits(ctx.vfs_file_id(), editor);
|
|
},
|
|
)
|
|
}
|
|
|
|
fn generate_fn(fn_: &ast::Fn, new_method_name: &str) -> Option<ast::Fn> {
|
|
let fn_ = fn_.reset_indent().clone_subtree();
|
|
let mut editor = SyntaxEditor::new(fn_.syntax().clone());
|
|
|
|
// index -> index_mut
|
|
let fn_name = fn_.name()?;
|
|
let new_name = make::name(new_method_name);
|
|
editor.replace(fn_name.syntax(), new_name.syntax().clone_for_update());
|
|
|
|
// &self -> &mut self
|
|
let self_param: ast::SelfParam = fn_.syntax().descendants().find_map(ast::SelfParam::cast)?;
|
|
let mut_self_param = make::mut_self_param();
|
|
editor.replace(self_param.syntax(), mut_self_param.syntax().clone_for_update());
|
|
|
|
// &Self::Output -> &mut Self::Output
|
|
let ret_type = fn_.ret_type()?;
|
|
let new_ret_type = make::ret_type(process_ret_type(&ret_type)?).clone_for_update();
|
|
editor.replace(ret_type.syntax(), new_ret_type.syntax());
|
|
|
|
let expr = fn_.body()?.tail_expr()?;
|
|
match &expr {
|
|
ast::Expr::RefExpr(ref_expr) if ref_expr.mut_token().is_none() => {
|
|
editor.insert_all(
|
|
Position::after(ref_expr.amp_token()?),
|
|
vec![make::token(T![mut]).into(), make::tokens::whitespace(" ").into()],
|
|
);
|
|
}
|
|
_ => {}
|
|
}
|
|
|
|
let fn_ = editor.finish().new_root().clone();
|
|
ast::Fn::cast(fn_)
|
|
}
|
|
|
|
fn get_trait_mut(apply_trait: &hir::Trait, famous: FamousDefs<'_, '_>) -> Option<&'static str> {
|
|
let trait_ = Some(apply_trait);
|
|
if trait_ == famous.core_convert_Index().as_ref() {
|
|
return Some("IndexMut");
|
|
}
|
|
if trait_ == famous.core_convert_AsRef().as_ref() {
|
|
return Some("AsMut");
|
|
}
|
|
if trait_ == famous.core_borrow_Borrow().as_ref() {
|
|
return Some("BorrowMut");
|
|
}
|
|
if trait_ == famous.core_ops_Deref().as_ref() {
|
|
return Some("DerefMut");
|
|
}
|
|
None
|
|
}
|
|
|
|
fn process_method_name(name: ast::Name) -> Option<&'static str> {
|
|
let new_name = match &*name.text() {
|
|
"index" => "index_mut",
|
|
"as_ref" => "as_mut",
|
|
"borrow" => "borrow_mut",
|
|
"deref" => "deref_mut",
|
|
_ => return None,
|
|
};
|
|
Some(new_name)
|
|
}
|
|
|
|
fn process_ret_type(ref_ty: &ast::RetType) -> Option<ast::Type> {
|
|
let ty = ref_ty.ty()?;
|
|
let ast::Type::RefType(ref_type) = ty else {
|
|
return None;
|
|
};
|
|
Some(make::ty_ref(ref_type.ty()?, true))
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use crate::{
|
|
AssistConfig,
|
|
tests::{TEST_CONFIG, check_assist, check_assist_not_applicable, check_assist_with_config},
|
|
};
|
|
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_generate_mut_trait_impl() {
|
|
check_assist(
|
|
generate_mut_trait_impl,
|
|
r#"
|
|
//- minicore: index
|
|
pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
|
|
impl<T> core::ops::Index$0<Axis> for [T; 3] {
|
|
type Output = T;
|
|
|
|
fn index(&self, index: Axis) -> &Self::Output {
|
|
&self[index as usize]
|
|
}
|
|
}
|
|
"#,
|
|
r#"
|
|
pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
|
|
$0impl<T> core::ops::IndexMut<Axis> for [T; 3] {
|
|
fn index_mut(&mut self, index: Axis) -> &mut Self::Output {
|
|
&mut self[index as usize]
|
|
}
|
|
}
|
|
|
|
impl<T> core::ops::Index<Axis> for [T; 3] {
|
|
type Output = T;
|
|
|
|
fn index(&self, index: Axis) -> &Self::Output {
|
|
&self[index as usize]
|
|
}
|
|
}
|
|
"#,
|
|
);
|
|
|
|
check_assist(
|
|
generate_mut_trait_impl,
|
|
r#"
|
|
//- minicore: index
|
|
pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
|
|
impl<T> core::ops::Index$0<Axis> for [T; 3] where T: Copy {
|
|
type Output = T;
|
|
|
|
fn index(&self, index: Axis) -> &Self::Output {
|
|
let var_name = &self[index as usize];
|
|
var_name
|
|
}
|
|
}
|
|
"#,
|
|
r#"
|
|
pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
|
|
$0impl<T> core::ops::IndexMut<Axis> for [T; 3]
|
|
where T: Copy
|
|
{
|
|
fn index_mut(&mut self, index: Axis) -> &mut Self::Output {
|
|
let var_name = &self[index as usize];
|
|
var_name
|
|
}
|
|
}
|
|
|
|
impl<T> core::ops::Index<Axis> for [T; 3] where T: Copy {
|
|
type Output = T;
|
|
|
|
fn index(&self, index: Axis) -> &Self::Output {
|
|
let var_name = &self[index as usize];
|
|
var_name
|
|
}
|
|
}
|
|
"#,
|
|
);
|
|
|
|
check_assist(
|
|
generate_mut_trait_impl,
|
|
r#"
|
|
//- minicore: as_ref
|
|
struct Foo(i32);
|
|
|
|
impl core::convert::AsRef$0<i32> for Foo {
|
|
fn as_ref(&self) -> &i32 {
|
|
&self.0
|
|
}
|
|
}
|
|
"#,
|
|
r#"
|
|
struct Foo(i32);
|
|
|
|
$0impl core::convert::AsMut<i32> for Foo {
|
|
fn as_mut(&mut self) -> &mut i32 {
|
|
&mut self.0
|
|
}
|
|
}
|
|
|
|
impl core::convert::AsRef<i32> for Foo {
|
|
fn as_ref(&self) -> &i32 {
|
|
&self.0
|
|
}
|
|
}
|
|
"#,
|
|
);
|
|
|
|
check_assist(
|
|
generate_mut_trait_impl,
|
|
r#"
|
|
//- minicore: deref
|
|
struct Foo(i32);
|
|
|
|
impl core::ops::Deref$0 for Foo {
|
|
type Target = i32;
|
|
|
|
fn deref(&self) -> &Self::Target {
|
|
&self.0
|
|
}
|
|
}
|
|
"#,
|
|
r#"
|
|
struct Foo(i32);
|
|
|
|
$0impl core::ops::DerefMut for Foo {
|
|
fn deref_mut(&mut self) -> &mut Self::Target {
|
|
&mut self.0
|
|
}
|
|
}
|
|
|
|
impl core::ops::Deref for Foo {
|
|
type Target = i32;
|
|
|
|
fn deref(&self) -> &Self::Target {
|
|
&self.0
|
|
}
|
|
}
|
|
"#,
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn test_generate_mut_trait_impl_non_zero_indent() {
|
|
check_assist(
|
|
generate_mut_trait_impl,
|
|
r#"
|
|
//- minicore: index
|
|
mod foo {
|
|
pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
|
|
impl<T> core::ops::Index$0<Axis> for [T; 3] where T: Copy {
|
|
type Output = T;
|
|
|
|
fn index(&self, index: Axis) -> &Self::Output {
|
|
let var_name = &self[index as usize];
|
|
var_name
|
|
}
|
|
}
|
|
}
|
|
"#,
|
|
r#"
|
|
mod foo {
|
|
pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
|
|
$0impl<T> core::ops::IndexMut<Axis> for [T; 3]
|
|
where T: Copy
|
|
{
|
|
fn index_mut(&mut self, index: Axis) -> &mut Self::Output {
|
|
let var_name = &self[index as usize];
|
|
var_name
|
|
}
|
|
}
|
|
|
|
impl<T> core::ops::Index<Axis> for [T; 3] where T: Copy {
|
|
type Output = T;
|
|
|
|
fn index(&self, index: Axis) -> &Self::Output {
|
|
let var_name = &self[index as usize];
|
|
var_name
|
|
}
|
|
}
|
|
}
|
|
"#,
|
|
);
|
|
|
|
check_assist(
|
|
generate_mut_trait_impl,
|
|
r#"
|
|
//- minicore: index
|
|
mod foo {
|
|
mod bar {
|
|
pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
|
|
impl<T> core::ops::Index$0<Axis> for [T; 3] where T: Copy {
|
|
type Output = T;
|
|
|
|
fn index(&self, index: Axis) -> &Self::Output {
|
|
let var_name = &self[index as usize];
|
|
var_name
|
|
}
|
|
}
|
|
}
|
|
}
|
|
"#,
|
|
r#"
|
|
mod foo {
|
|
mod bar {
|
|
pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
|
|
$0impl<T> core::ops::IndexMut<Axis> for [T; 3]
|
|
where T: Copy
|
|
{
|
|
fn index_mut(&mut self, index: Axis) -> &mut Self::Output {
|
|
let var_name = &self[index as usize];
|
|
var_name
|
|
}
|
|
}
|
|
|
|
impl<T> core::ops::Index<Axis> for [T; 3] where T: Copy {
|
|
type Output = T;
|
|
|
|
fn index(&self, index: Axis) -> &Self::Output {
|
|
let var_name = &self[index as usize];
|
|
var_name
|
|
}
|
|
}
|
|
}
|
|
}
|
|
"#,
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn test_generate_mut_trait_impl_not_applicable() {
|
|
check_assist_not_applicable(
|
|
generate_mut_trait_impl,
|
|
r#"
|
|
pub trait Index<Idx: ?Sized> {}
|
|
|
|
impl<T> Index$0<i32> for [T; 3] {}
|
|
"#,
|
|
);
|
|
check_assist_not_applicable(
|
|
generate_mut_trait_impl,
|
|
r#"
|
|
pub trait AsRef<T: ?Sized> {}
|
|
|
|
impl AsRef$0<i32> for [T; 3] {}
|
|
"#,
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn no_snippets() {
|
|
check_assist_with_config(
|
|
generate_mut_trait_impl,
|
|
AssistConfig { snippet_cap: None, ..TEST_CONFIG },
|
|
r#"
|
|
//- minicore: index
|
|
pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
|
|
impl<T> core::ops::Index$0<Axis> for [T; 3] {
|
|
type Output = T;
|
|
|
|
fn index(&self, index: Axis) -> &Self::Output {
|
|
&self[index as usize]
|
|
}
|
|
}
|
|
"#,
|
|
r#"
|
|
pub enum Axis { X = 0, Y = 1, Z = 2 }
|
|
|
|
impl<T> core::ops::IndexMut<Axis> for [T; 3] {
|
|
fn index_mut(&mut self, index: Axis) -> &mut Self::Output {
|
|
&mut self[index as usize]
|
|
}
|
|
}
|
|
|
|
impl<T> core::ops::Index<Axis> for [T; 3] {
|
|
type Output = T;
|
|
|
|
fn index(&self, index: Axis) -> &Self::Output {
|
|
&self[index as usize]
|
|
}
|
|
}
|
|
"#,
|
|
);
|
|
}
|
|
}
|