language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-10-03 15:14:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

unmark changed callback as experimental

Browse source 
Closes #112
This commit is contained in:
Olivier Goffart 2024-09-09 14:40:16 +02:00 • committed by GitHub
parent e79dcc4bec
commit 0feb674612
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 0 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

5
docs/reference/src/language/syntax/properties.md
View file

@ -151,11 +151,8 @@ export component Example inherits Window {
} }
``` ```
<!--
## Change Callbacks ## Change Callbacks
**This feature is still experimental**
In Slint, it's possible to define a callback that is invoked when a property's value changes. In Slint, it's possible to define a callback that is invoked when a property's value changes.
```slint ```slint
@ -213,5 +210,3 @@ Using a changed callback forces immediate evaluation of bindings, which are typi
This practice also compromises the purity of bindings, complicating edits via graphical editors. This practice also compromises the purity of bindings, complicating edits via graphical editors.
Accumulating excessive changed events can introduce issues and bugs, especially in scenarios involving loops, where a change callback modifies a property, potentially triggering changes to the same property. Accumulating excessive changed events can introduce issues and bugs, especially in scenarios involving loops, where a change callback modifies a property, potentially triggering changes to the same property.
-->

4
examples/weather-demo/build.rs
View file

@ -1,10 +1,6 @@
// Copyright © SixtyFPS GmbH <info@slint.dev> // Copyright © SixtyFPS GmbH <info@slint.dev>
// SPDX-License-Identifier: MIT // SPDX-License-Identifier: MIT
use std::env;
fn main() { fn main() {
env::set_var("SLINT_ENABLE_EXPERIMENTAL_FEATURES", "true");
slint_build::compile("ui/main.slint").unwrap(); slint_build::compile("ui/main.slint").unwrap();
} }

6
internal/compiler/object_tree.rs
View file

@ -1354,12 +1354,6 @@ impl Element {
} }
for ch in node.PropertyChangedCallback() { for ch in node.PropertyChangedCallback() {
if !diag.enable_experimental && !tr.expose_internal_types {
diag.push_error(
"Change callbacks are experimental and not yet implemented in this version of Slint".into(),
&ch,
);
}
let Some(prop) = parser::identifier_text(&ch.DeclaredIdentifier()) else { continue }; let Some(prop) = parser::identifier_text(&ch.DeclaredIdentifier()) else { continue };
let lookup_result = r.lookup_property(&prop); let lookup_result = r.lookup_property(&prop);
if !lookup_result.is_valid() { if !lookup_result.is_valid() {