language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-11-01 20:31:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

core: Do not report singleshot timers set up via start() as running

Browse source 
... after firing once. `running()` will now return `true` for such timers
till just before the callback is run and `false` after that point.

Add test a new test and update existing C++ tests to make them comply
with the changed behavior.
This commit is contained in:
Tobias Hunger 2023-11-30 11:56:29 +01:00 • committed by Tobias Hunger
parent 36dfaf3af6
commit 471bef422d
3 changed files with 134 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

15
api/cpp/tests/eventloop.cpp
View file

@ -1,6 +1,8 @@
// Copyright © SixtyFPS GmbH <info@slint.dev>
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-1.1 OR LicenseRef-Slint-commercial
// cSpell: ignore singleshot
#define CATCH_CONFIG_MAIN
#include "catch2/catch.hpp"
@ -52,8 +54,9 @@ TEST_CASE("C++ Restart Singleshot Timer")
[&]() { timer_triggered++; });
REQUIRE(timer_triggered == 0);
REQUIRE(timer.running());
bool timer_was_running = false;
bool timer_was_running = true;
slint::Timer::single_shot(std::chrono::milliseconds(500), [&]() {
timer_was_running = timer.running();
@ -62,10 +65,15 @@ TEST_CASE("C++ Restart Singleshot Timer")
slint::run_event_loop();
REQUIRE(!timer.running());
REQUIRE(timer_triggered == 1);
REQUIRE(timer_was_running);
REQUIRE(!timer_was_running); // At that point the timer is already considered stopped!
timer_triggered = 0;
timer_was_running = true;
timer.restart();
REQUIRE(timer.running());
slint::Timer::single_shot(std::chrono::milliseconds(500), [&]() {
timer_was_running = timer.running();
slint::quit_event_loop();
@ -74,7 +82,8 @@ TEST_CASE("C++ Restart Singleshot Timer")
slint::run_event_loop();
REQUIRE(timer_triggered == 1);
REQUIRE(timer_was_running);
REQUIRE(!timer_was_running);
REQUIRE(!timer.running());
}
TEST_CASE("C++ Restart Repeated Timer")