language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-08-04 18:58:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Auto-fixed clippy::needless_borrow

Browse source 
`__CARGO_FIX_YOLO=1` is a hack, but it does help a lot with the tedious fixes where the result is fairly clear.

See https://rust-lang.github.io/rust-clippy/master/index.html#/needless_borrow

```
__CARGO_FIX_YOLO=1 cargo clippy --fix --all-targets --workspace --exclude gstreamer-player --exclude i-slint-backend-linuxkms --exclude uefi-demo --exclude ffmpeg -- -A clippy::all -W clippy::needless_borrow

cargo fmt --all
```
This commit is contained in:
Yuri Astrakhan 2025-02-07 00:49:51 -05:00 • committed by Olivier Goffart
parent bcb2953f00
commit 6324b35e94
26 changed files with 59 additions and 59 deletions
Download patch file Download diff file Expand all files Collapse all files

8
internal/compiler/generator/rust.rs
View file

@ -201,7 +201,7 @@ pub fn generate(
.iter_enumerated()
.filter(|(_, glob)| glob.must_generate())
.map(|(idx, glob)| generate_global(idx, glob, &llr));
let shared_globals = generate_shared_globals(&llr, &compiler_config);
let shared_globals = generate_shared_globals(&llr, compiler_config);
let globals_ids = llr.globals.iter().filter(|glob| glob.exported).flat_map(|glob| {
std::iter::once(ident(&glob.name)).chain(glob.aliases.iter().map(|x| ident(x)))
});
@ -697,7 +697,7 @@ fn generate_sub_component(
)
})
.chain(component.menu_item_trees.iter().map(|tree| {
generate_item_tree(&tree, root, Some(ParentCtx::new(&ctx, None)), None, false)
generate_item_tree(tree, root, Some(ParentCtx::new(&ctx, None)), None, false)
}))
.collect::<Vec<_>>();
@ -1780,7 +1780,7 @@ fn generate_repeated_component(
};
let root_sc = &unit.sub_components[repeated.sub_tree.root];
let inner_component_id = self::inner_component_id(&root_sc);
let inner_component_id = self::inner_component_id(root_sc);
let extra_fn = if let Some(listview) = &repeated.listview {
let p_y = access_member(&listview.prop_y, &ctx).unwrap();
@ -2702,7 +2702,7 @@ fn compile_builtin_function_call(
ctx.compilation_unit,
popup.item_tree.root,
RustGeneratorContext { global_access: quote!(_self.globals.get().unwrap()) },
Some(ParentCtx::new(&ctx, None)),
Some(ParentCtx::new(ctx, None)),
);
let position = compile_expression(&popup.position.borrow(), &popup_ctx);