language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-08-04 18:58:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

ListView: fix continuous redraw with fluent style

Browse source 
Because we set the viewport-width several time to different value during
the layouting of the ListView, it will cause this property to always be
dirty. In particular, this causes permanent restart of the fluent's
scrollbar animation on the size of the handle, causing continous
repaints.
This commit is contained in:
Olivier Goffart 2025-01-20 17:55:23 +01:00
parent 5806b027ff
commit 7e37f19e2c
5 changed files with 19 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

12
internal/compiler/generator/cpp.rs
View file

@ -2493,18 +2493,12 @@ fn generate_repeated_component(
Access::Public, // Because Repeater accesses it
Declaration::Function(Function {
name: "listview_layout".into(),
signature:
"(float *offset_y, const slint::private_api::Property<float> *viewport_width) const -> void"
.to_owned(),
signature: "(float *offset_y) const -> float".to_owned(),
statements: Some(vec![
"[[maybe_unused]] auto self = this;".into(),
"float vp_w = viewport_width->get();".to_owned(),
format!("{}.set(*offset_y);", p_y), // FIXME: shouldn't that be handled by apply layout?
format!("{}.set(*offset_y);", p_y),
format!("*offset_y += {}.get();", p_height),
format!("float w = {}.get();", p_width),
"if (vp_w < w)".to_owned(),
" viewport_width->set(w);".to_owned(),
format!("return {}.get();", p_width),
]),
..Function::default()
}),