language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-08-31 07:37:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Introduce error handling in the FemtoVG and Skia renderers (#2402)

Browse source 
Avoid unwrap() and expect() and instead propagate errors all the way
down to run_event_loop(), show(), and hide() in the Slint AIP.
This commit is contained in:
Simon Hausmann 2023-03-24 14:18:11 +01:00 • committed by GitHub
parent 7f95614a98
commit 8ffb5131c7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
28 changed files with 627 additions and 357 deletions
Download patch file Download diff file Expand all files Collapse all files

7
internal/interpreter/api.rs
View file

@ -1045,17 +1045,16 @@ impl ComponentHandle for ComponentInstance {
comp.borrow_instance().window_adapter().window().show()
}
fn hide(&self) {
fn hide(&self) -> Result<(), PlatformError> {
generativity::make_guard!(guard);
let comp = self.inner.unerase(guard);
comp.borrow_instance().window_adapter().window().hide();
comp.borrow_instance().window_adapter().window().hide()
}
fn run(&self) -> Result<(), PlatformError> {
self.show()?;
run_event_loop()?;
self.hide();
Ok(())
self.hide()
}
fn window(&self) -> &Window {

2
internal/interpreter/ffi.rs
View file

@ -562,7 +562,7 @@ pub extern "C" fn slint_interpreter_component_instance_show(
if is_visible {
comp.borrow_instance().window_adapter().show().unwrap();
} else {
comp.borrow_instance().window_adapter().hide();
comp.borrow_instance().window_adapter().hide().unwrap();
}
}