language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-08-04 10:50:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

C++: fix a bug in which a substraction could overflow

Browse source 
There was an image like this:
```slint
height: 40px
Image {
     width: parent.width;
     height: self.source.height * 1px;
     source: @image-url("....");
}
```

The `y` propery ended inlined like so:
`(40 - the_image.source.get().size().height)/float(2)`
but since height was `unsigned` the C++ rules means that the operation
happens as unsigned and we have an overflow. and `y` turned out to be
very big instead of slightly negative (for image whose height was larger
than 40)
This commit is contained in:
Olivier Goffart 2025-03-04 22:47:50 +01:00
parent da33ffa6f5
commit a6a142f9c8
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
internal/compiler/generator/cpp.rs
View file

@ -3268,6 +3268,7 @@ fn compile_expression(expr: &llr::Expression, ctx: &EvaluationContext) -> String
'&' => "&&",
'|' => "||",
'/' => "/(float)",
'-' => "-(float)", // conversion to float to avoid overflow between unsigned
_ => op.encode_utf8(&mut buffer),
},
)

3
tests/cases/elements/image.slint
View file

@ -21,8 +21,9 @@ TestCase := Rectangle {
property <length> img_width: img.width;
property <length> img_height: img.height;
in-out property <float> test_no_overflow: (21 - img.source.width) / 2; // (21 - 320)/2 = -149.5
property <bool> test: img2.source-clip-height * 1px == img2.height && img2.source-clip-width * 1px == img2.width &&
img2.width/1px == img2.source.width - 20 && img3.source.width == 0 && img3.source.height == 0;
img2.width/1px == img2.source.width - 20 && img3.source.width == 0 && img3.source.height == 0 && test_no_overflow == -149.5;
}
/*