language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-08-04 18:58:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix cmake producing absolute DT_NEEDED paths in applications when linking against installed libslint_cpp on Linux

Browse source 
Commit 9b62b08ed6 fixed
https://github.com/slint-ui/slint/issues/1066 initially, but commit
1036c0d082 erroneously regressed this
again, because while Corrosion sets this property, it is only set on the
locally generated CMake target. We still need to propagate that also
into the installed CMake target, which this patch does.
This commit is contained in:
Simon Hausmann 2023-10-05 15:32:06 +02:00 • committed by Simon Hausmann
parent dbabb33c45
commit a982bdebe2
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
api/cpp/CMakeLists.txt
View file

@ -386,6 +386,16 @@ if(SLINT_BUILD_RUNTIME)
endif()
endforeach()
# Corrosion sets IMPORTED_NO_SONAME and for macOS we reset that
# and set IMPORTED_SONAME. Make sure to propagate these locally
# set properties also to the installed cmake target.
foreach(prop IMPORTED_NO_SONAME IMPORTED_SONAME)
get_target_property(value ${slint_cpp_impl} ${prop})
if(value)
list(APPEND SLINT_LIB_PROPERTIES ${prop} ${value})
endif()
endforeach()
get_property(_SLINT_STYLE GLOBAL PROPERTY SLINT_STYLE)
configure_package_config_file("cmake/SlintConfig.cmake.in" "${CMAKE_CURRENT_BINARY_DIR}/lib/cmake/Slint/SlintConfig.cmake" INSTALL_DESTINATION lib/cmake/Slint)
endfunction()