language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-12-23 09:19:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix NO_TTY error from pnpm launched by test-driver-nodejs (#10268)
Some checks are pending
autofix.ci / format_fix (push) Waiting to run
Details
autofix.ci / lint_typecheck (push) Waiting to run
Details
autofix.ci / ci (push) Blocked by required conditions
Details

Browse source 
I copied my slint checkout from one compter to another, and it ended up
in a different path. Running test-driver-nodejs on the new computer gave this error:
ERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTY  Aborted removal of modules directory due to no TTY
If you are running pnpm in CI, set the CI environment variable to "true".

This is because pnpm detects that the nodes-module directory isn't as
expected (wrong path in the storeDir key of .modules.yaml), and wants
to wipe it out. But first, it wants to ask for confirmation...
and it fails because there's no TTY (pnpm being launched indirectly).

This is fixed by --config.confirmModulesPurge=false
(or --force, or setting the env var CI to true)

See references in the comments
This commit is contained in:
David Faure 2025-12-11 20:32:26 +01:00 • committed by GitHub
parent eb40c440a7
commit b0a36680c6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tests/driver/nodejs/nodejs.rs
View file

@ -22,12 +22,13 @@ static NODE_API_JS_PATH: LazyLock<PathBuf> = LazyLock::new(|| {
// On Windows pnpm is 'pnpm.cmd', which Rust's process::Command doesn't look for as extension, because
// it tries to emulate CreateProcess.
let pnpm = which::which("pnpm").unwrap();
let pnpm = which::which("pnpm").expect("pnpm must be installed to run the nodejs tests");
// installs the slint node package dependencies
let o = std::process::Command::new(pnpm.clone())
.arg("install")
.arg("--ignore-scripts")
.arg("--config.confirmModulesPurge=false") // https://github.com/pnpm/pnpm/issues/9973 (and 7727 for the solution)
.current_dir(node_dir.clone())
.stdout(std::process::Stdio::piped())
.stderr(std::process::Stdio::piped())
@ -45,7 +46,7 @@ static NODE_API_JS_PATH: LazyLock<PathBuf> = LazyLock::new(|| {
.stdout(std::process::Stdio::piped())
.stderr(std::process::Stdio::piped())
.output()
.map_err(|err| format!("Could not launch pnpm install: {err}"))
.map_err(|err| format!("Could not launch pnpm run: {err}"))
.unwrap();
check_output(o);