language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-10-27 18:36:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Hide Android selection handles when scrolled out of view

Browse source 
In a LineEdit with a long text, when dragging the selection
to the point where the anchor scrolls out of view in the other
direection, it used to keep being visible, outside the LineEdit.

This commit fixes that by passing the clip rect to the java code
that positions the selection handles.
This commit is contained in:
David Faure 2025-09-14 01:29:41 +02:00 • committed by Olivier Goffart
parent 92ebe92f62
commit b23a657c44
4 changed files with 43 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
internal/backends/android-activity/javahelper.rs
View file

@ -194,15 +194,22 @@ impl JavaHelper {
};
env.delete_local_ref(class_it)?;
let cur_origin = data.cursor_rect_origin.to_physical(scale_factor);
let cur_origin = data.cursor_rect_origin.to_physical(scale_factor); // i32
let anchor_origin = data.anchor_point.to_physical(scale_factor);
let cur_size = data.cursor_rect_size.to_physical(scale_factor);
let cur_visible = data.clip_rect.map_or(true, |r| {
r.contains(i_slint_core::lengths::logical_point_from_api(data.cursor_rect_origin))
});
let anchor_visible = data.clip_rect.map_or(true, |r| {
r.contains(i_slint_core::lengths::logical_point_from_api(data.anchor_point))
});
// Add 2*cur_size.width to the y position to be a bit under the cursor
let cursor_height = cur_size.height as i32 + 2 * cur_size.width as i32;
let cur_x = cur_origin.x + cur_size.width as i32 / 2;
let cur_x = if cur_visible { cur_origin.x + cur_size.width as i32 / 2 } else { -1 };
let cur_y = cur_origin.y + cursor_height;
let anchor_x = anchor_origin.x;
let anchor_x = if anchor_visible { anchor_origin.x } else { -1 };
let anchor_y = anchor_origin.y + 2 * cur_size.width as i32;
env.call_method(