language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-08-04 10:50:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Make sure that the Clip element created for a visible binding has an empty size

Browse source 
The `inject_element_as_repeated_element` will create width and height
binding that we should not have.

Fixes #1846
This commit is contained in:
Olivier Goffart 2022-11-14 10:54:48 +01:00 • committed by Olivier Goffart
parent cbe2d6d631
commit d2fdd161e9
2 changed files with 56 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
internal/compiler/passes/visible.rs
View file

@ -48,10 +48,11 @@ pub fn handle_visible(component: &Rc<Component>, type_register: &TypeRegister) {
if child.borrow().repeated.is_some() {
let root_elem = child.borrow().base_type.as_component().root_element.clone();
if has_visible_binding(&root_elem) {
object_tree::inject_element_as_repeated_element(
&child,
create_visibility_element(&root_elem, &native_clip),
)
let clip_elem = create_visibility_element(&root_elem, &native_clip);
object_tree::inject_element_as_repeated_element(&child, clip_elem.clone());
// The width and the height must be null
clip_elem.borrow_mut().bindings.remove("width");
clip_elem.borrow_mut().bindings.remove("height");
}
} else if has_visible_binding(&child) {
let new_child = create_visibility_element(&child, &native_clip);