language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-08-04 18:58:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Use to_smolstr in a few more places to reduce allocation pressure

Browse source 
Before:
```
Benchmark 1: ./target/release/slint-viewer ../slint-perf/app.slint
  Time (mean ± σ):     626.1 ms ±  16.0 ms    [User: 548.6 ms, System: 72.6 ms]
  Range (min … max):   610.9 ms … 653.0 ms    10 runs

        allocations:            3395727
        temporary allocations:  466634
```

After:
```
Benchmark 1: ./target/release/slint-viewer ../slint-perf/app.slint
  Time (mean ± σ):     622.6 ms ±  13.9 ms    [User: 556.6 ms, System: 63.5 ms]
  Range (min … max):   609.7 ms … 645.4 ms    10 runs

        allocations:            3371931
        temporary allocations:  459315
```
This commit is contained in:
Milian Wolff 2024-10-16 11:06:35 +02:00 • committed by Olivier Goffart
parent fe2679e3ac
commit d3905b4c41
5 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

8
internal/compiler/object_tree.rs
View file

@ -896,7 +896,7 @@ impl Element {
) -> ElementRc {
let base_type = if let Some(base_node) = node.QualifiedName() {
let base = QualifiedTypeName::from_node(base_node.clone());
let base_string = base.to_string();
let base_string = base.to_smolstr();
match parent_type.lookup_type_for_child_element(&base_string, tr) {
Ok(ElementType::Component(c)) if c.is_global() => {
diag.push_error(
@ -1509,7 +1509,7 @@ impl Element {
}
}
if r.borrow().base_type.to_string() == "ListView" {
if r.borrow().base_type.to_smolstr() == "ListView" {
let mut seen_for = false;
for se in node.children() {
if se.kind() == SyntaxKind::RepeatedElement && !seen_for {
@ -1662,7 +1662,7 @@ impl Element {
match lookup_result.property_type {
Type::Invalid => {
if self.base_type != ElementType::Error {
diag.push_error(if self.base_type.to_string() == "Empty" {
diag.push_error(if self.base_type.to_smolstr() == "Empty" {
format!( "Unknown property {unresolved_name}")
} else {
format!( "Unknown property {unresolved_name} in {}", self.base_type)
@ -1871,7 +1871,7 @@ pub fn type_from_node(
let prop_type = tr.lookup_qualified(&qualified_type.members);
if prop_type == Type::Invalid && tr.lookup_element(&qualified_type.to_string()).is_err() {
if prop_type == Type::Invalid && tr.lookup_element(&qualified_type.to_smolstr()).is_err() {
diag.push_error(format!("Unknown type '{}'", qualified_type), &qualified_type_node);
} else if !prop_type.is_property_type() {
diag.push_error(