language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-10-01 06:11:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Fix memory leak in the C++ SharedVector

Browse source 
detaching in the destructor is not a good idea, make sure to use the const version
This commit is contained in:
Olivier Goffart 2021-11-26 15:00:44 +01:00
parent cba553b9f7
commit d9637816bb
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
api/sixtyfps-cpp/include/sixtyfps_sharedvector.h
View file

@ -175,7 +175,7 @@ private:
void drop() void drop()
{ {
if (inner->refcount > 0 && (--inner->refcount) == 0) { if (inner->refcount > 0 && (--inner->refcount) == 0) {
auto b = begin(), e = end(); auto b = cbegin(), e = cend();
for (auto it = b; it < e; ++it) { for (auto it = b; it < e; ++it) {
it->~T(); it->~T();
} }