language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-08-04 18:58:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Change the new error that detects binding loop through the window into a warning

Browse source 
In 80de96488a (#3397) we introduced a new
error if we detect a binding loop from the Window geomerty to its layout.
But it looks like this causes a lot of error in existing project, so
make it a warning instead.

It will continue to be an error in the live preview as this will cause a
panic otherwise.

This commit also change the text of the error to include the actual
binding loop. I hope this makes it easier for users to see the loop and
help to fix it.
This commit is contained in:
Olivier Goffart 2025-06-02 16:57:18 +02:00
parent 118d85dfc7
commit db18f4e2e5
21 changed files with 189 additions and 145 deletions
Download patch file Download diff file Expand all files Collapse all files

5
internal/compiler/lib.rs
View file

@ -148,6 +148,10 @@ pub struct CompilerConfiguration {
/// C++ namespace
pub cpp_namespace: Option<String>,
/// When true, fail the build when a binding loop is detected with a window layout property
/// (otherwise this is a compatibility warning)
pub error_on_binding_loop_with_window_layout: bool,
/// Generate debug information for elements (ids, type names)
pub debug_info: bool,
@ -232,6 +236,7 @@ impl CompilerConfiguration {
translation_domain: None,
no_native_menu: false,
cpp_namespace,
error_on_binding_loop_with_window_layout: false,
debug_info,
debug_hooks: None,
components_to_generate: ComponentSelection::ExportedWindows,

2
internal/compiler/passes.rs
View file

@ -208,7 +208,7 @@ pub async fn run_passes(
doc.used_types.borrow_mut().sub_components.clear();
}
binding_analysis::binding_analysis(doc, diag);
binding_analysis::binding_analysis(doc, &type_loader.compiler_config, diag);
unique_id::assign_unique_id(doc);
doc.visit_all_used_components(|component| {

67
internal/compiler/passes/binding_analysis.rs
View file

@ -18,6 +18,7 @@ use crate::object_tree::{find_parent_element, Document, ElementRc, PropertyAnima
use derive_more as dm;
use crate::expression_tree::Callable;
use crate::CompilerConfiguration;
use smol_str::{SmolStr, ToSmolStr};
/// Maps the alias in the other direction than what the BindingExpression::two_way_binding does.
@ -25,11 +26,20 @@ use smol_str::{SmolStr, ToSmolStr};
/// ReverseAliases maps B to A.
type ReverseAliases = HashMap<NamedReference, Vec<NamedReference>>;
pub fn binding_analysis(doc: &Document, diag: &mut BuildDiagnostics) {
pub fn binding_analysis(
doc: &Document,
compiler_config: &CompilerConfiguration,
diag: &mut BuildDiagnostics,
) {
let mut reverse_aliases = Default::default();
mark_used_base_properties(doc);
propagate_is_set_on_aliases(doc, &mut reverse_aliases);
perform_binding_analysis(doc, &reverse_aliases, diag);
perform_binding_analysis(
doc,
&reverse_aliases,
compiler_config.error_on_binding_loop_with_window_layout,
diag,
);
}
/// A reference to a property which might be deep in a component path.
@ -114,15 +124,22 @@ impl From<NamedReference> for PropertyPath {
#[derive(Default)]
struct AnalysisContext {
visited: HashSet<PropertyPath>,
/// The stack of properties that depends on each other
currently_analyzing: linked_hash_set::LinkedHashSet<PropertyPath>,
/// When set, one of the property in the `currently_analyzing` stack is the window layout property
/// And we should issue a warning if that's part of a loop instead of an error
window_layout_property: Option<PropertyPath>,
error_on_binding_loop_with_window_layout: bool,
}
fn perform_binding_analysis(
doc: &Document,
reverse_aliases: &ReverseAliases,
error_on_binding_loop_with_window_layout: bool,
diag: &mut BuildDiagnostics,
) {
let mut context = AnalysisContext::default();
let mut context =
AnalysisContext { error_on_binding_loop_with_window_layout, ..Default::default() };
doc.visit_all_used_components(|component| {
crate::object_tree::recurse_elem_including_sub_components_no_borrow(
component,
@ -232,6 +249,28 @@ fn analyze_binding(
}
if context.currently_analyzing.contains(current) {
let mut loop_description = String::new();
let mut has_window_layout = false;
for it in context.currently_analyzing.iter().rev() {
if context.window_layout_property.as_ref().is_some_and(|p| p == it) {
has_window_layout = true;
}
if !loop_description.is_empty() {
loop_description.push_str(" -> ");
}
match it.prop.element().borrow().id.as_str() {
"" => loop_description.push_str(it.prop.name()),
id => {
loop_description.push_str(id);
loop_description.push_str(".");
loop_description.push_str(it.prop.name());
}
}
if it == current {
break;
}
}
for it in context.currently_analyzing.iter().rev() {
let p = &it.prop;
let elem = p.element();
@ -241,11 +280,12 @@ fn analyze_binding(
break;
}
diag.push_error(
format!("The binding for the property '{}' is part of a binding loop", p.name()),
&binding.span.clone().unwrap_or_else(|| elem.to_source_location()),
);
let span = binding.span.clone().unwrap_or_else(|| elem.to_source_location());
if !context.error_on_binding_loop_with_window_layout && has_window_layout {
diag.push_warning(format!("The binding for the property '{}' is part of a binding loop ({loop_description}).\nThis was allowed in previous version of Slint, but is deprecated and may cause panic at runtime", p.name()), &span);
} else {
diag.push_error(format!("The binding for the property '{}' is part of a binding loop ({loop_description})", p.name()), &span);
}
if it == current {
break;
}
@ -592,13 +632,10 @@ fn visit_builtin_property(
root = e.0.clone();
}
if let Some(p) = root.borrow().layout_info_prop(orientation) {
process_property(
&p.clone().into(),
ReadType::NativeRead,
context,
reverse_aliases,
diag,
);
let path = PropertyPath::from(p.clone());
let old_layout = context.window_layout_property.replace(path.clone());
process_property(&path, ReadType::NativeRead, context, reverse_aliases, diag);
context.window_layout_property = old_layout;
};
}
}

20
internal/compiler/tests/syntax/analysis/binding_loop1.slint
View file

@ -7,7 +7,7 @@ WithStates := Rectangle {
property <brush> extra_background;
property <bool> condition;
background: yellow; //FIXME: ideally we'd keep the span within the state
// ^error{The binding for the property 'background' is part of a binding loop}
// ^error{The binding for the property 'background' is part of a binding loop (extra-background -> background)}
states [
xxx when condition : {
background: extra_background;
@ -19,29 +19,29 @@ export Test := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
property <int> a: 45 + root.b;
// ^error{The binding for the property 'a' is part of a binding loop}
// ^error{The binding for the property 'a' is part of a binding loop (root_window.d -> root_window.c -> root_window.b -> root_window.a)}
property <float> b: root.c;
// ^error{The binding for the property 'b' is part of a binding loop}
// ^error{The binding for the property 'b' is part of a binding loop (root_window.d -> root_window.c -> root_window.b -> root_window.a)}
property <int> c <=> d;
// ^error{The binding for the property 'c' is part of a binding loop}
// ^error{The binding for the property 'c' is part of a binding loop (root_window.d -> root_window.c -> root_window.b -> root_window.a)}
property <int> d: root.a + root.e;
// ^error{The binding for the property 'd' is part of a binding loop}
// ^error{The binding for the property 'd' is part of a binding loop (root_window.d -> root_window.c -> root_window.b -> root_window.a)}
property <int> e: root.b;
// ^error{The binding for the property 'e' is part of a binding loop}
// ^error{The binding for the property 'e' is part of a binding loop (root_window.e -> root_window.d -> root_window.c -> root_window.b)}
property <int> w: root.a + root.b; // This id not part of a loop
property<bool> cond: xx.x == 0;
// ^error{The binding for the property 'cond' is part of a binding loop}
// ^error{The binding for the property 'cond' is part of a binding loop (xx.y -> xx.x -> root_window.cond)}
xx := Rectangle {
x: y;
// ^error{The binding for the property 'x' is part of a binding loop}
// ^error{The binding for the property 'x' is part of a binding loop (xx.y -> xx.x -> root_window.cond)}
y: root.cond ? 42px : 55px;
// ^error{The binding for the property 'y' is part of a binding loop}
// ^error{The binding for the property 'y' is part of a binding loop (xx.y -> xx.x -> root_window.cond)}
}
WithStates {
extra_background: background;
// ^error{The binding for the property 'extra-background' is part of a binding loop}
// ^error{The binding for the property 'extra-background' is part of a binding loop (extra-background -> background)}
}
}

20
internal/compiler/tests/syntax/analysis/binding_loop2.slint
View file

@ -6,7 +6,7 @@ T1 := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
property <int> foo;
property <int> bar: foo;
// ^error{The binding for the property 'bar' is part of a binding loop}
// ^error{The binding for the property 'bar' is part of a binding loop (foo -> bar)}
Text { text: bar; }
}
@ -14,23 +14,23 @@ T2 := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
property <string> t2_text;
t:= Text { text: t2_text; }
// ^error{The binding for the property 'text' is part of a binding loop}
// ^^error{The binding for the property 'text' is part of a binding loop}
// ^error{The binding for the property 'text' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
// ^^error{The binding for the property 'text' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
property t_alias <=> t.text;
// ^error{The binding for the property 't-alias' is part of a binding loop}
// ^^error{The binding for the property 't-alias' is part of a binding loop}
// ^error{The binding for the property 't-alias' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
// ^^error{The binding for the property 't-alias' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
}
T3 := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
property <string> hello;
property <string> al <=> a.t_alias;
// ^error{The binding for the property 'al' is part of a binding loop}
// ^error{The binding for the property 'al' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
HorizontalLayout {
a := T2 { t2_text: b.t_alias; }
// ^error{The binding for the property 't2-text' is part of a binding loop}
// ^error{The binding for the property 't2-text' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
b := T2 { t2_text: root.hello; }
// ^error{The binding for the property 't2-text' is part of a binding loop}
// ^error{The binding for the property 't2-text' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
}
}
@ -46,9 +46,9 @@ export App := Rectangle {
VerticalLayout {
T1 { foo: 44; }
T1 { foo: bar; }
// ^error{The binding for the property 'foo' is part of a binding loop}
// ^error{The binding for the property 'foo' is part of a binding loop (foo -> bar)}
T3 { hello: al; }
// ^error{The binding for the property 'hello' is part of a binding loop}
// ^error{The binding for the property 'hello' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
T4 { my_property: my_property; }
// ^error{Property 'my-property' cannot refer to itself}

10
internal/compiler/tests/syntax/analysis/binding_loop_function.slint
View file

@ -5,28 +5,28 @@ Compo1 := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
property <int> a : aa();
// ^error{The binding for the property 'a' is part of a binding loop}
// ^error{The binding for the property 'a' is part of a binding loop (cc.aa -> cc.a)}
pure callback aa() -> int;
function factorial(n: int) -> int {
// ^error{The binding for the property 'factorial' is part of a binding loop}
// ^error{The binding for the property 'factorial' is part of a binding loop (cc.factorial)}
return n == 0 ? 1 : factorial(n - 1) * n;
}
property <int> b;
public pure function bb() -> int { return b; }
// ^error{The binding for the property 'bb' is part of a binding loop}
// ^error{The binding for the property 'bb' is part of a binding loop (cc.bb -> cc.b)}
}
export App := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
cc := Compo1 {
aa() => { return self.a; }
// ^error{The binding for the property 'aa' is part of a binding loop}
// ^error{The binding for the property 'aa' is part of a binding loop (cc.aa -> cc.a)}
b: self.bb();
// ^error{The binding for the property 'b' is part of a binding loop}
// ^error{The binding for the property 'b' is part of a binding loop (cc.bb -> cc.b)}
}

4
internal/compiler/tests/syntax/analysis/binding_loop_issue_772.slint
View file

@ -10,10 +10,10 @@ Alias := Rectangle {
export Foo := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
property <int> base-prop: alias.viewport_width;
// ^error{The binding for the property 'base-prop' is part of a binding loop}
// ^error{The binding for the property 'base-prop' is part of a binding loop (alias.ps-width -> root_window.base-prop)}
alias := Alias { ps_width: base-prop; }
// ^error{The binding for the property 'ps-width' is part of a binding loop}
// ^error{The binding for the property 'ps-width' is part of a binding loop (alias.ps-width -> root_window.base-prop)}
Text {
text: base-prop;

40
internal/compiler/tests/syntax/analysis/binding_loop_layout.slint
View file

@ -3,16 +3,16 @@
TC := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop (tc.preferred-width -> tc.width -> outer.width -> inner.width -> inner-inner.width -> inner.layoutinfo-h -> outer.layoutinfo-h -> tc.layoutinfo-h)}
outer := VerticalLayout {
// ^error{The binding for the property 'width' is part of a binding loop}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'width' is part of a binding loop (tc.preferred-width -> tc.width -> outer.width -> inner.width -> inner-inner.width -> inner.layoutinfo-h -> outer.layoutinfo-h -> tc.layoutinfo-h)}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop (tc.preferred-width -> tc.width -> outer.width -> inner.width -> inner-inner.width -> inner.layoutinfo-h -> outer.layoutinfo-h -> tc.layoutinfo-h)}
inner := HorizontalLayout {
// ^error{The binding for the property 'width' is part of a binding loop}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'width' is part of a binding loop (tc.preferred-width -> tc.width -> outer.width -> inner.width -> inner-inner.width -> inner.layoutinfo-h -> outer.layoutinfo-h -> tc.layoutinfo-h)}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop (tc.preferred-width -> tc.width -> outer.width -> inner.width -> inner-inner.width -> inner.layoutinfo-h -> outer.layoutinfo-h -> tc.layoutinfo-h)}
inner_inner := VerticalLayout {
width: parent.width;
// ^error{The binding for the property 'width' is part of a binding loop}
// ^error{The binding for the property 'width' is part of a binding loop (tc.preferred-width -> tc.width -> outer.width -> inner.width -> inner-inner.width -> inner.layoutinfo-h -> outer.layoutinfo-h -> tc.layoutinfo-h)}
Rectangle {}
}
}
@ -22,35 +22,35 @@ TC := Rectangle {
export Test := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
// ^^error{The binding for the property 'width' is part of a binding loop}
// ^^warning{The binding for the property 'width' is part of a binding loop (root.width -> l.width -> l.layout-cache -> width -> l.layoutinfo-v -> l.preferred-height -> text -> l.layoutinfo-h -> root.layoutinfo-h -> root_window.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
VerticalLayout { // FIXME: That's an internal property, but people might understand
// ^error{The binding for the property 'min-width' is part of a binding loop}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'min-width' is part of a binding loop (min-width -> width -> layoutinfo-h)}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop (min-width -> width -> layoutinfo-h)}
Rectangle {
width: parent.min_width;
// ^error{The binding for the property 'width' is part of a binding loop}
// ^error{The binding for the property 'width' is part of a binding loop (min-width -> width -> layoutinfo-h)}
}
}
l := HorizontalLayout { // FIXME: That's an internal property, but people might understand
// ^error{The binding for the property 'preferred-width' is part of a binding loop}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^^^error{The binding for the property 'layoutinfo-v' is part of a binding loop}
// ^^^^error{The binding for the property 'preferred-height' is part of a binding loop}
// ^^^^^error{The binding for the property 'width' is part of a binding loop}
// ^^^^^^error{The binding for the property 'layout-cache' is part of a binding loop}
// ^^^^^^^error{The binding for the property 'width' is part of a binding loop}
// ^error{The binding for the property 'preferred-width' is part of a binding loop (l.preferred-width -> text -> l.layoutinfo-h)}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop (l.preferred-width -> text -> l.layoutinfo-h)}
// ^^^error{The binding for the property 'layoutinfo-v' is part of a binding loop (l.layoutinfo-v -> l.preferred-height -> text)}
// ^^^^error{The binding for the property 'preferred-height' is part of a binding loop (l.layoutinfo-v -> l.preferred-height -> text)}
// ^^^^^warning{The binding for the property 'width' is part of a binding loop (root.width -> l.width -> l.layout-cache -> width -> l.layoutinfo-v -> l.preferred-height -> text -> l.layoutinfo-h -> root.layoutinfo-h -> root_window.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^^^^warning{The binding for the property 'layout-cache' is part of a binding loop (root.width -> l.width -> l.layout-cache -> width -> l.layoutinfo-v -> l.preferred-height -> text -> l.layoutinfo-h -> root.layoutinfo-h -> root_window.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^^^^^warning{The binding for the property 'width' is part of a binding loop (root.width -> l.width -> l.layout-cache -> width -> l.layoutinfo-v -> l.preferred-height -> text -> l.layoutinfo-h -> root.layoutinfo-h -> root_window.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
Text {
text: "hello \{l.preferred-width/1px}x\{l.preferred-height/1px}";
// ^error{The binding for the property 'text' is part of a binding loop}
// ^error{The binding for the property 'text' is part of a binding loop (l.preferred-width -> text -> l.layoutinfo-h)}
wrap: word-wrap;
}
}
tc := TC {
// ^error{The binding for the property 'preferred-width' is part of a binding loop}
// ^error{The binding for the property 'preferred-width' is part of a binding loop (tc.preferred-width -> tc.width -> outer.width -> inner.width -> inner-inner.width -> inner.layoutinfo-h -> outer.layoutinfo-h -> tc.layoutinfo-h)}
width: preferred-width;
// ^error{The binding for the property 'width' is part of a binding loop}
// ^error{The binding for the property 'width' is part of a binding loop (tc.preferred-width -> tc.width -> outer.width -> inner.width -> inner-inner.width -> inner.layoutinfo-h -> outer.layoutinfo-h -> tc.layoutinfo-h)}
}
}

36
internal/compiler/tests/syntax/analysis/binding_loop_layout2.slint
View file

@ -6,19 +6,19 @@ Wrap := Rectangle {
property woo <=> text.wrap;
VerticalLayout {
// ^error{The binding for the property 'layout-cache' is part of a binding loop}
// ^^error{The binding for the property 'height' is part of a binding loop}
// ^error{The binding for the property 'layout-cache' is part of a binding loop (layout-cache -> text.width -> layoutinfo-v -> layout-cache -> height -> square.height -> square.width)}
// ^^error{The binding for the property 'height' is part of a binding loop (layout-cache -> text.width -> layoutinfo-v -> layout-cache -> height -> square.height -> square.width)}
HorizontalLayout {
// ^error{The binding for the property 'layout-cache' is part of a binding loop}
// ^^error{The binding for the property 'width' is part of a binding loop}
// ^^^error{The binding for the property 'layoutinfo-v' is part of a binding loop}
// ^error{The binding for the property 'layout-cache' is part of a binding loop (layout-cache -> text.width -> layoutinfo-v -> layout-cache -> height -> square.height -> square.width)}
// ^^error{The binding for the property 'width' is part of a binding loop (layout-cache -> text.width -> layoutinfo-v -> layout-cache -> height -> square.height -> square.width)}
// ^^^error{The binding for the property 'layoutinfo-v' is part of a binding loop (layout-cache -> text.width -> layoutinfo-v -> layout-cache -> height -> square.height -> square.width)}
text := Text {
text: "Hello World";
}
square := Rectangle {
// ^error{The binding for the property 'height' is part of a binding loop}
// ^error{The binding for the property 'height' is part of a binding loop (layout-cache -> text.width -> layoutinfo-v -> layout-cache -> height -> square.height -> square.width)}
width: height;
// ^error{The binding for the property 'width' is part of a binding loop}
// ^error{The binding for the property 'width' is part of a binding loop (layout-cache -> text.width -> layoutinfo-v -> layout-cache -> height -> square.height -> square.width)}
background: violet;
}
}
@ -29,19 +29,19 @@ Wrap := Rectangle {
export Test := Window {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
// ^^error{The binding for the property 'layoutinfo-v' is part of a binding loop}
// ^^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^^warning{The binding for the property 'layoutinfo-v' is part of a binding loop (width -> layout-cache-h -> width -> layoutinfo-v -> root.layoutinfo-v -> height -> layout-cache-v -> height -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^warning{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> layout-cache-h -> width -> layoutinfo-v -> root.layoutinfo-v -> height -> layout-cache-v -> height -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
property <image> source;
GridLayout {
// ^error{The binding for the property 'width' is part of a binding loop}
// ^^error{The binding for the property 'layout-cache-h' is part of a binding loop}
// ^^^error{The binding for the property 'width' is part of a binding loop}
// ^^^^error{The binding for the property 'layoutinfo-v' is part of a binding loop}
// ^^^^^error{The binding for the property 'height' is part of a binding loop}
// ^^^^^^error{The binding for the property 'layout-cache-v' is part of a binding loop}
// ^^^^^^^error{The binding for the property 'height' is part of a binding loop}
// ^^^^^^^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^warning{The binding for the property 'width' is part of a binding loop (width -> layout-cache-h -> width -> layoutinfo-v -> root.layoutinfo-v -> height -> layout-cache-v -> height -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^warning{The binding for the property 'layout-cache-h' is part of a binding loop (width -> layout-cache-h -> width -> layoutinfo-v -> root.layoutinfo-v -> height -> layout-cache-v -> height -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^warning{The binding for the property 'width' is part of a binding loop (width -> layout-cache-h -> width -> layoutinfo-v -> root.layoutinfo-v -> height -> layout-cache-v -> height -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^^warning{The binding for the property 'layoutinfo-v' is part of a binding loop (width -> layout-cache-h -> width -> layoutinfo-v -> root.layoutinfo-v -> height -> layout-cache-v -> height -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^^^warning{The binding for the property 'height' is part of a binding loop (width -> layout-cache-h -> width -> layoutinfo-v -> root.layoutinfo-v -> height -> layout-cache-v -> height -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^^^^warning{The binding for the property 'layout-cache-v' is part of a binding loop (width -> layout-cache-h -> width -> layoutinfo-v -> root.layoutinfo-v -> height -> layout-cache-v -> height -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^^^^^warning{The binding for the property 'height' is part of a binding loop (width -> layout-cache-h -> width -> layoutinfo-v -> root.layoutinfo-v -> height -> layout-cache-v -> height -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^^^^^^warning{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> layout-cache-h -> width -> layoutinfo-v -> root.layoutinfo-v -> height -> layout-cache-v -> height -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
Image {
@ -49,7 +49,7 @@ export Test := Window {
}
Rectangle {
width: height;
// ^error{The binding for the property 'width' is part of a binding loop}
// ^warning{The binding for the property 'width' is part of a binding loop (width -> layout-cache-h -> width -> layoutinfo-v -> root.layoutinfo-v -> height -> layout-cache-v -> height -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
}
}

14
internal/compiler/tests/syntax/analysis/binding_loop_layout3.slint
View file

@ -3,19 +3,19 @@
Compo := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop (preferred-width -> the-text -> text -> layoutinfo-h -> layoutinfo-h -> lay.layoutinfo-h -> layoutinfo-h)}
property <string> the_text;
lay := HorizontalLayout {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop (preferred-width -> the-text -> text -> layoutinfo-h -> layoutinfo-h -> lay.layoutinfo-h -> layoutinfo-h)}
if true : Rectangle {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop (preferred-width -> the-text -> text -> layoutinfo-h -> layoutinfo-h -> lay.layoutinfo-h -> layoutinfo-h)}
VerticalLayout {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop (preferred-width -> the-text -> text -> layoutinfo-h -> layoutinfo-h -> lay.layoutinfo-h -> layoutinfo-h)}
Text {
text: root.the_text;
// ^error{The binding for the property 'text' is part of a binding loop}
// ^error{The binding for the property 'text' is part of a binding loop (preferred-width -> the-text -> text -> layoutinfo-h -> layoutinfo-h -> lay.layoutinfo-h -> layoutinfo-h)}
}
}
}
@ -26,8 +26,8 @@ Compo := Rectangle {
export Foo := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
Compo {
// ^error{The binding for the property 'preferred-width' is part of a binding loop}
// ^error{The binding for the property 'preferred-width' is part of a binding loop (preferred-width -> the-text -> text -> layoutinfo-h -> layoutinfo-h -> lay.layoutinfo-h -> layoutinfo-h)}
the_text: self.preferred-width / 1px;
// ^error{The binding for the property 'the-text' is part of a binding loop}
// ^error{The binding for the property 'the-text' is part of a binding loop (preferred-width -> the-text -> text -> layoutinfo-h -> layoutinfo-h -> lay.layoutinfo-h -> layoutinfo-h)}
}
}

40
internal/compiler/tests/syntax/analysis/binding_loop_layout4.slint
View file

@ -2,35 +2,35 @@
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0
component Foo {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> width -> layout-cache -> width -> font-size -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache)}
HorizontalLayout {
// ^error{The binding for the property 'layout-cache' is part of a binding loop}
// ^^error{The binding for the property 'width' is part of a binding loop}
// ^^^error{The binding for the property 'width' is part of a binding loop}
// ^^^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^^^^^error{The binding for the property 'layout-cache' is part of a binding loop}
// ^^^^^^error{The binding for the property 'width' is part of a binding loop}
// ^^^^^^^error{The binding for the property 'width' is part of a binding loop}
// ^^^^^^^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
// ^^error{The binding for the property 'width' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
// ^^^error{The binding for the property 'layout-cache' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
// ^^^^error{The binding for the property 'width' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
// ^^^^^error{The binding for the property 'width' is part of a binding loop (width -> width -> layout-cache -> width -> font-size -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache)}
// ^^^^^^error{The binding for the property 'layout-cache' is part of a binding loop (width -> width -> layout-cache -> width -> font-size -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache)}
// ^^^^^^^error{The binding for the property 'width' is part of a binding loop (width -> width -> layout-cache -> width -> font-size -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache)}
// ^^^^^^^^error{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> width -> layout-cache -> width -> font-size -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache)}
Text {
text: "hello";
font_size: self.width / 2.5;
// ^error{The binding for the property 'font-size' is part of a binding loop}
// ^^error{The binding for the property 'font-size' is part of a binding loop}
// ^error{The binding for the property 'font-size' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
// ^^error{The binding for the property 'font-size' is part of a binding loop (width -> width -> layout-cache -> width -> font-size -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache)}
}
}
}
component Bar {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
HorizontalLayout {
// ^error{The binding for the property 'layout-cache' is part of a binding loop}
// ^^error{The binding for the property 'width' is part of a binding loop}
// ^^^error{The binding for the property 'width' is part of a binding loop}
// ^^^^error{The binding for the property 'width' is part of a binding loop}
// ^^^^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
// ^^error{The binding for the property 'width' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
// ^^^error{The binding for the property 'layout-cache' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
// ^^^^error{The binding for the property 'width' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
// ^^^^^error{The binding for the property 'width' is part of a binding loop (width -> width -> layout-cache -> width -> font-size -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache)}
Foo {}
Foo {}
}
@ -38,6 +38,6 @@ component Bar {
export component Apps inherits Window {
Bar {}
// ^error{The binding for the property 'preferred-width' is part of a binding loop}
// ^^error{The binding for the property 'width' is part of a binding loop}
// ^error{The binding for the property 'preferred-width' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
// ^^error{The binding for the property 'width' is part of a binding loop (layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> preferred-width -> width -> width -> layout-cache -> width -> width -> layout-cache -> width -> font-size)}
}

26
internal/compiler/tests/syntax/analysis/binding_loop_layout_if.slint
View file

@ -6,37 +6,37 @@ component Wrapper {
height: 100%;
Rectangle {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layout-cache)}
VerticalLayout {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layout-cache)}
if root.width > 200px: Rectangle { }
}
}
}
component WrapperInherited inherits Rectangle {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^warning{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> width -> layout-cache -> width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
VerticalLayout {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^warning{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> width -> layout-cache -> width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
if root.width > 200px: Rectangle { }
}
}
export component Test inherits Window {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^warning{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> width -> layout-cache -> width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
VerticalLayout {
// ^error{The binding for the property 'width' is part of a binding loop}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^warning{The binding for the property 'width' is part of a binding loop (width -> width -> layout-cache -> width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^warning{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> width -> layout-cache -> width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
HorizontalLayout {
// ^error{The binding for the property 'width' is part of a binding loop}
// ^^error{The binding for the property 'width' is part of a binding loop}
// ^^^error{The binding for the property 'layout-cache' is part of a binding loop}
// ^^^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^^^^^error{The binding for the property 'width' is part of a binding loop}
// ^warning{The binding for the property 'width' is part of a binding loop (width -> width -> layout-cache -> width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^warning{The binding for the property 'layout-cache' is part of a binding loop (width -> width -> layout-cache -> width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^warning{The binding for the property 'width' is part of a binding loop (width -> width -> layout-cache -> width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^^warning{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> width -> layout-cache -> width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^^^^error{The binding for the property 'width' is part of a binding loop (width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layout-cache)}
WrapperInherited { }
Wrapper { }
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> layoutinfo-h -> layoutinfo-h -> layoutinfo-h -> layout-cache)}
}
}
}

4
internal/compiler/tests/syntax/analysis/binding_loop_mappointtowindow.slint
View file

@ -6,9 +6,9 @@ export App := Rectangle {
Rectangle {
x: inner.absolute-position.x > 10px ? 10px : 0px;
// ^error{The binding for the property 'x' is part of a binding loop}
// ^error{The binding for the property 'x' is part of a binding loop (inner.absolute-position -> x)}
inner := Rectangle {
// ^error{The binding for the property 'absolute-position' is part of a binding loop}
// ^error{The binding for the property 'absolute-position' is part of a binding loop (inner.absolute-position -> x)}
}
}

6
internal/compiler/tests/syntax/analysis/binding_loop_self.slint
View file

@ -12,11 +12,11 @@ export Test := Rectangle {
property <int> num_elements;
num-elements: 4;
Key { pos: 1; num_elements: num_elements; }
// ^error{The binding for the property 'num-elements' is part of a binding loop}
// ^error{The binding for the property 'num-elements' is part of a binding loop (num-elements)}
Key { pos: 2; num_elements: self.num_elements; }
// ^error{The binding for the property 'num-elements' is part of a binding loop}
// ^error{The binding for the property 'num-elements' is part of a binding loop (num-elements)}
Key { pos: 3; num_elements: parent.num_elements; }
Key { pos: 4; num_elements: num_elements; }
// ^error{The binding for the property 'num-elements' is part of a binding loop}
// ^error{The binding for the property 'num-elements' is part of a binding loop (num-elements)}
}
}

12
internal/compiler/tests/syntax/analysis/binding_loop_text.slint
View file

@ -3,14 +3,14 @@
export component Test {
Text { font-size: self.font-metrics.ascent; }
// ^error{The binding for the property 'font-size' is part of a binding loop}
// ^^error{The binding for the property 'font-metrics' is part of a binding loop}
// ^error{The binding for the property 'font-metrics' is part of a binding loop (font-metrics -> font-size)}
// ^^error{The binding for the property 'font-size' is part of a binding loop (font-metrics -> font-size)}
t1 := Text { font-italic: t2.font-metrics.cap-height > 10px; }
// ^error{The binding for the property 'font-italic' is part of a binding loop}
// ^^error{The binding for the property 'font-metrics' is part of a binding loop}
// ^error{The binding for the property 'font-metrics' is part of a binding loop (t2.font-metrics -> t1.font-italic -> t1.font-metrics -> t2.font-weight)}
// ^^error{The binding for the property 'font-italic' is part of a binding loop (t2.font-metrics -> t1.font-italic -> t1.font-metrics -> t2.font-weight)}
t2 := Text { font-weight: t1.font-metrics.descent / 0.5px; }
// ^error{The binding for the property 'font-weight' is part of a binding loop}
// ^^error{The binding for the property 'font-metrics' is part of a binding loop}
// ^error{The binding for the property 'font-metrics' is part of a binding loop (t2.font-metrics -> t1.font-italic -> t1.font-metrics -> t2.font-weight)}
// ^^error{The binding for the property 'font-weight' is part of a binding loop (t2.font-metrics -> t1.font-italic -> t1.font-metrics -> t2.font-weight)}
}

8
internal/compiler/tests/syntax/analysis/binding_loop_window.slint
View file

@ -6,16 +6,16 @@
import { HorizontalBox, VerticalBox } from "std-widgets.slint";
export component MainWindow inherits Window {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^warning{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
HorizontalBox {
// ^error{The binding for the property 'width' is part of a binding loop}
// ^^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^warning{The binding for the property 'width' is part of a binding loop (width -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
// ^^warning{The binding for the property 'layoutinfo-h' is part of a binding loop (width -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
VerticalBox {
width: parent.width;
// ^error{The binding for the property 'width' is part of a binding loop}
// ^warning{The binding for the property 'width' is part of a binding loop (width -> width -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
//height: parent.height;
Text {
text: "Test";

6
internal/compiler/tests/syntax/analysis/binding_loop_window2.slint
View file

@ -3,12 +3,12 @@
// Issue #3898
export component LspCrash inherits Window {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^warning{The binding for the property 'layoutinfo-h' is part of a binding loop (padding-left -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
HorizontalLayout {
// ^error{The binding for the property 'layoutinfo-h' is part of a binding loop}
// ^warning{The binding for the property 'layoutinfo-h' is part of a binding loop (padding-left -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
padding-left: parent.width * 0.015;
// ^error{The binding for the property 'padding-left' is part of a binding loop}
// ^warning{The binding for the property 'padding-left' is part of a binding loop (padding-left -> layoutinfo-h -> root.layoutinfo-h).↵This was allowed in previous version of Slint, but is deprecated and may cause panic at runtime}
Rectangle {}
}
}

4
internal/compiler/tests/syntax/functions/functions_purity_recursive_5220.slint
View file

@ -13,9 +13,9 @@ export component App inherits Window{
in property <int> abc: get_abc1();
function get_abc1() -> int { return get_abc2(); }
// ^error{The binding for the property 'get-abc1' is part of a binding loop}
// ^error{The binding for the property 'get-abc1' is part of a binding loop (root.get-abc2 -> root.get-abc1)}
function get_abc2() -> int { return get_abc1(); }
// ^error{The binding for the property 'get-abc2' is part of a binding loop}
// ^error{The binding for the property 'get-abc2' is part of a binding loop (root.get-abc2 -> root.get-abc1)}
}

4
internal/compiler/tests/syntax/lookup/two_way_binding.slint
View file

@ -37,9 +37,9 @@ export X := Rectangle {
Rectangle {
x <=> self.loop_on_x;
// ^error{The binding for the property 'x' is part of a binding loop}
// ^error{The binding for the property 'x' is part of a binding loop (x -> loop-on-x)}
property <length> loop_on_x <=> x;
// ^error{The binding for the property 'loop-on-x' is part of a binding loop}
// ^error{The binding for the property 'loop-on-x' is part of a binding loop (x -> loop-on-x)}
}
property gyoyo <=> G.yoyo;

4
internal/compiler/tests/typeloader/incpath/should_fail4.slint
View file

@ -11,7 +11,7 @@ export Unused := Rectangle {
export Z := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
property <int> b1: b2;
// ^error{The binding for the property 'b1' is part of a binding loop}
// ^error{The binding for the property 'b1' is part of a binding loop (b2 -> b1)}
property <int> b2: b1;
// ^error{The binding for the property 'b2' is part of a binding loop}
// ^error{The binding for the property 'b2' is part of a binding loop (b2 -> b1)}
}