language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-08-04 18:58:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Change the new error that detects binding loop through the window into a warning

Browse source 
In 80de96488a (#3397) we introduced a new
error if we detect a binding loop from the Window geomerty to its layout.
But it looks like this causes a lot of error in existing project, so
make it a warning instead.

It will continue to be an error in the live preview as this will cause a
panic otherwise.

This commit also change the text of the error to include the actual
binding loop. I hope this makes it easier for users to see the loop and
help to fix it.
This commit is contained in:
Olivier Goffart 2025-06-02 16:57:18 +02:00
parent 118d85dfc7
commit db18f4e2e5
21 changed files with 189 additions and 145 deletions
Download patch file Download diff file Expand all files Collapse all files

20
internal/compiler/tests/syntax/analysis/binding_loop2.slint
View file

@ -6,7 +6,7 @@ T1 := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
property <int> foo;
property <int> bar: foo;
// ^error{The binding for the property 'bar' is part of a binding loop}
// ^error{The binding for the property 'bar' is part of a binding loop (foo -> bar)}
Text { text: bar; }
}
@ -14,23 +14,23 @@ T2 := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
property <string> t2_text;
t:= Text { text: t2_text; }
// ^error{The binding for the property 'text' is part of a binding loop}
// ^^error{The binding for the property 'text' is part of a binding loop}
// ^error{The binding for the property 'text' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
// ^^error{The binding for the property 'text' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
property t_alias <=> t.text;
// ^error{The binding for the property 't-alias' is part of a binding loop}
// ^^error{The binding for the property 't-alias' is part of a binding loop}
// ^error{The binding for the property 't-alias' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
// ^^error{The binding for the property 't-alias' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
}
T3 := Rectangle {
// ^warning{':=' to declare a component is deprecated. The new syntax declare components with 'component MyComponent {'. Read the documentation for more info}
property <string> hello;
property <string> al <=> a.t_alias;
// ^error{The binding for the property 'al' is part of a binding loop}
// ^error{The binding for the property 'al' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
HorizontalLayout {
a := T2 { t2_text: b.t_alias; }
// ^error{The binding for the property 't2-text' is part of a binding loop}
// ^error{The binding for the property 't2-text' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
b := T2 { t2_text: root.hello; }
// ^error{The binding for the property 't2-text' is part of a binding loop}
// ^error{The binding for the property 't2-text' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
}
}
@ -46,9 +46,9 @@ export App := Rectangle {
VerticalLayout {
T1 { foo: 44; }
T1 { foo: bar; }
// ^error{The binding for the property 'foo' is part of a binding loop}
// ^error{The binding for the property 'foo' is part of a binding loop (foo -> bar)}
T3 { hello: al; }
// ^error{The binding for the property 'hello' is part of a binding loop}
// ^error{The binding for the property 'hello' is part of a binding loop (hello -> b.t2-text -> t.text -> b.t-alias -> a.t2-text -> t.text -> a.t-alias -> al)}
T4 { my_property: my_property; }
// ^error{Property 'my-property' cannot refer to itself}