language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-10-01 22:31:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Issue a warning when accessing a deprecated property through component scopes

Browse source
This commit is contained in:
Simon Hausmann 2021-02-03 07:59:58 +01:00
parent c771bcff45
commit e8b64be9bd
3 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
sixtyfps_compiler/passes/resolving.rs
View file

@ -584,6 +584,9 @@ impl Expression {
let PropertyLookupResult { resolved_name, property_type } =
elem.borrow().lookup_property(&first_str);
if property_type.is_property_type() {
if resolved_name.as_ref() != &first_str {
ctx.diag.push_property_deprecation_warning(&first_str, &resolved_name, &first);
}
let prop = Self::PropertyReference(NamedReference {
element: Rc::downgrade(&elem),
name: resolved_name.to_string(),

6
sixtyfps_compiler/tests/syntax/lookup/deprecated_property.60
View file

@ -20,4 +20,10 @@ Xxx := Rectangle {
duration: 250ms;
}
}
callback not_called;
not_called() => {
color = #000000;
// ^warning{The property 'color' has been deprecated. Please use 'background' instead}
}
}

2
sixtyfps_compiler/tests/syntax/lookup/signal_arg.60
View file

@ -13,7 +13,7 @@ Xxx := Rectangle {
property <color> glop_col;
property <string> blah: "yo";
plop(x, blah, hello) => {
color = blah;
background = blah;
x = 42 + hello;
// ^error{Assignement need to be done on a property}
width = x;