language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-10-02 14:51:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Throw an error when a callback aliases itself

Browse source 
Instead of panicking
Fixes #4938
This commit is contained in:
Olivier Goffart 2024-03-26 16:14:57 +01:00
parent 18eea8602a
commit ea0227098a
2 changed files with 17 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
internal/compiler/passes/infer_aliases_types.rs
View file

@ -92,10 +92,18 @@ fn resolve_alias(
let mut ty = Type::Invalid;
if let Some(nr) = &nr {
let element = nr.element();
let same_element = Rc::ptr_eq(&element, elem);
if same_element && nr.name() == prop {
diag.push_error(
format!("Cannot alias to itself"),
&elem.borrow().property_declarations[prop].type_node(),
);
return;
}
ty = nr.ty();
if matches!(ty, Type::InferredCallback | Type::InferredProperty) {
let element = nr.element();
if Rc::ptr_eq(&element, elem) {
if same_element {
resolve_alias(&element, nr.name(), scope, type_register, diag)
} else {
resolve_alias(&element, nr.name(), &recompute_scope(&element), type_register, diag)

7
internal/compiler/tests/syntax/lookup/callback_alias_issue4938.slint Normal file
View file

@ -0,0 +1,7 @@
// Copyright © SixtyFPS GmbH <info@slint.dev>
// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-1.1 OR LicenseRef-Slint-commercial
export component Xxx {
callback issue4938 <=> issue4938;
// ^error{Cannot alias to itself}
}