language-servers/slint
1
0
Fork 0
mirror of https://github.com/slint-ui/slint.git synced 2025-11-01 12:24:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Node.js: Fix support for loadFile() with an URL on Windows

Browse source 
We recommend the use of `loadFile(new URL("...", import.metal.url))`,
but this never worked on Windows, because we're not using the API
the Node.js docs even recommend to correctly covert to a local path on Windows.

(Apply the same logic to initTranslations)

Fixes #8209
This commit is contained in:
Simon Hausmann 2025-04-22 17:07:58 +02:00 • committed by Simon Hausmann
parent 5dc8410f0a
commit f94e5a73b0
2 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
api/node/__test__/api.spec.mts
View file

@ -13,7 +13,13 @@ const dirname = path.dirname(
// loadFile api
test("loadFile", (t) => {
const demo = loadFile(path.join(dirname, "resources/test.slint")) as any;
// Test the URL variant here, to ensure that it works (esp. on Windows)
const demo = loadFile(
new URL(
"resources/test.slint",
import.meta.url.replace("build", "__test__"),
),
) as any;
const test = new demo.Test();
t.is(test.check, "Test");

7
api/node/typescript/index.ts
View file

@ -16,6 +16,8 @@ export { ArrayModel } from "./models";
import { Diagnostic } from "../rust-module.cjs";
import { fileURLToPath } from "node:url";
/**
* Represents a two-dimensional point.
*/
@ -626,7 +628,8 @@ export function loadFile(
filePath: string | URL,
options?: LoadFileOptions,
): Object {
const pathname = filePath instanceof URL ? filePath.pathname : filePath;
const pathname =
filePath instanceof URL ? fileURLToPath(filePath) : filePath;
return loadSlint({
fileData: { filePath: pathname, options },
from: "file",
@ -948,7 +951,7 @@ export namespace private_api {
* ````
*/
export function initTranslations(domain: string, path: string | URL) {
const pathname = path instanceof URL ? path.pathname : path;
const pathname = path instanceof URL ? fileURLToPath(path) : path;
napi.initTranslations(domain, pathname);
}