This uses https://pre-commit.com/ to add git hooks
Short summary to get started:
* Run `pip install pre-commit` to install the pre-commit binary
* Run `pre-commit install` in the git repo to install the actual git hooks
Not sure all the tests make sense in this configuration, this is another
attempt to get the discussion started;-)
pre-commit will only look at updated files by default and will only run
the tests that make sense for that file. So runtime is reasonable with
the checks I am proposing. `pre-commit run --all-files` (which forces
the hooks to look at all files) takes below 4s on my machine. This will
be much longer if you start to add `cargo check` of course;-)
If you want to override a test for one commit, that is also pretty easy:
Just do `SKIP=test-name git commit`...
We should not increase the priority when merging two way binding, only when
inlining.
This fixes the iot-dashboard's devices widget which were sometimes not
transparent as they should have been.
This was not deterministic because the order in which the two way binding are
merged is not deterministic because of hash table, and sometimes one binding
ended up having a higher priority as it should have had.
Fix one vtable_address_comparisons clippy link.
It is fine to only compare the data pointer.
Two different model with the same data pointer in a Rc could only be obtained
with tricks like transmute because each model is allocated on a different Rc.
The layout of the html here is a bit different for the slize puzzle
than for other demo because it is using a display: grid.
As a result, placing the spinner in the grid would cause the canvas
to be resized when the spinner goes away, with firefox. Since we don't
get resize event when the canvas gets resized withtout the whole page
being resized, the scaling and coordinate were off.
So put the spinner outside of the grid
In Exports::from_node() we use parser::identifier_text to extract the
names, which are normalized (with dashes). We need to do the same in
ImportedName::from_node() in order to allow something like
export Main_Window := ...
and then
import { Main-Window } from "foo.60";
or even just
import { Main_Window } from "foo.60";
(that regressed)
The example are in a layout so "float:right" doesn't have an effect in that div
Instread, just put the preview inside the example.
This also remove the "Preview:" text